Skip to content

Commit b9b9209

Browse files
Fix nonconforming.yaml: remove false entries, add bytes NUL failures
The standard_rules/ignore and standard_rules/ignore_empty tests were never actually failing - they were passing all along, so removing them from expected failures (they were causing unexpected-pass failures). Add standard_rules/bytes IP/IPv4/IPv6/uuid failures that are caused by the C++ CEL runtime truncating bytes at embedded NUL bytes (e.g. IPv4 192.168.0.1 = \xc0\xa8\x00\x01 gets truncated at the NUL byte).
1 parent 5851044 commit b9b9209

1 file changed

Lines changed: 13 additions & 35 deletions

File tree

test/conformance/nonconforming.yaml

Lines changed: 13 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,3 @@
1-
# cel-expr-python cannot look up descriptors for nested message types in these
2-
# proto editions test cases. The C++ CEL runtime does not find the nested Msg
3-
# descriptor, producing a runtime error instead of a validation result.
4-
standard_rules/ignore:
5-
- proto/2023/message/explicit_presence/length_prefixed/ignore_unspecified/invalid/default
6-
- proto/2023/message/explicit_presence/length_prefixed/ignore_unspecified/invalid/populated
7-
- proto/2023/message/explicit_presence/length_prefixed/ignore_unspecified/valid/populated
8-
- proto/2023/message/explicit_presence/length_prefixed/ignore_empty/invalid/default
9-
- proto/2023/message/explicit_presence/length_prefixed/ignore_empty/invalid/populated
10-
- proto/2023/message/explicit_presence/length_prefixed/ignore_empty/valid/populated
11-
- proto/2023/message/explicit_presence/delimited/ignore_unspecified/invalid/default
12-
- proto/2023/message/explicit_presence/delimited/ignore_unspecified/invalid/populated
13-
- proto/2023/message/explicit_presence/delimited/ignore_unspecified/valid/populated
14-
- proto/2023/message/explicit_presence/delimited/ignore_empty/invalid/default
15-
- proto/2023/message/explicit_presence/delimited/ignore_empty/invalid/populated
16-
- proto/2023/message/explicit_presence/delimited/ignore_empty/valid/populated
17-
- proto/2023/message/legacy_required/length_prefixed/ignore_unspecified/invalid/default
18-
- proto/2023/message/legacy_required/length_prefixed/ignore_unspecified/invalid/populated
19-
- proto/2023/message/legacy_required/length_prefixed/ignore_unspecified/valid/populated
20-
- proto/2023/message/legacy_required/length_prefixed/ignore_empty/invalid/default
21-
- proto/2023/message/legacy_required/length_prefixed/ignore_empty/invalid/populated
22-
- proto/2023/message/legacy_required/length_prefixed/ignore_empty/valid/populated
23-
- proto/2023/message/legacy_required/delimited/ignore_unspecified/invalid/default
24-
- proto/2023/message/legacy_required/delimited/ignore_unspecified/invalid/populated
25-
- proto/2023/message/legacy_required/delimited/ignore_unspecified/valid/populated
26-
- proto/2023/message/legacy_required/delimited/ignore_empty/invalid/default
27-
- proto/2023/message/legacy_required/delimited/ignore_empty/invalid/populated
28-
- proto/2023/message/legacy_required/delimited/ignore_empty/valid/populated
29-
30-
standard_rules/ignore_empty:
31-
- proto/2023/message/explicit_presence/length_prefixed/nonzero
32-
- proto/2023/message/explicit_presence/length_prefixed/zero
33-
- proto/2023/message/explicit_presence/delimited/nonzero
34-
- proto/2023/message/explicit_presence/delimited/zero
35-
361
# cel-expr-python cannot look up the descriptor for the GroupCustom.Custom nested
372
# message type, which is a proto2 group-encoded field.
383
groups:
@@ -47,6 +12,19 @@ kitchen_sink:
4712
- field/transitive/invalid
4813
- many/all-non-message-fields/invalid
4914

15+
standard_rules/bytes:
16+
- IP/valid/v4
17+
- IP/valid/v6
18+
- IPv4/valid
19+
- IPv6/valid
20+
- uuid/valid/nil
21+
- uuid/valid/v1/lowercase
22+
- uuid/valid/v1/uppercase
23+
- uuid/valid/v2/lowercase
24+
- uuid/valid/v2/uppercase
25+
- uuid/valid/v4/lowercase
26+
- uuid/valid/v4/uppercase
27+
5028
standard_rules/string:
5129
- well_known_regex/header_name/strict/invalid/nul
5230
- well_known_regex/header_value/strict/invalid/nul

0 commit comments

Comments
 (0)