commit

Author: bufdev

cmd/ibctl/internal/command/holding/category/categorylist/categorylist.go

@@ -134,7 +134,7 @@ func run(ctx context.Context, container appext.Container, flags *flags) error {
 	// Override market prices and FX rates with real-time data from Yahoo Finance.
 	if flags.Realtime {
 		todayDate := time.Now().Format("2006-01-02")
-		if err := ibctlrealtime.ApplyOverrides(ctx, mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
+		if err := ibctlrealtime.ApplyOverrides(ctx, container.Logger(), mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
 			return err
 		}
 	}

cmd/ibctl/internal/command/holding/geo/geolist/geolist.go

@@ -135,7 +135,7 @@ func run(ctx context.Context, container appext.Container, flags *flags) error {
 	// Override market prices and FX rates with real-time data from Yahoo Finance.
 	if flags.Realtime {
 		todayDate := time.Now().Format("2006-01-02")
-		if err := ibctlrealtime.ApplyOverrides(ctx, mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
+		if err := ibctlrealtime.ApplyOverrides(ctx, container.Logger(), mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
 			return err
 		}
 	}

cmd/ibctl/internal/command/holding/holdinglist/holdinglist.go

@@ -164,7 +164,7 @@ func run(ctx context.Context, container appext.Container, flags *flags) error {
 	// Override market prices and FX rates with real-time data from Yahoo Finance.
 	if flags.Realtime {
 		todayDate := time.Now().Format("2006-01-02")
-		if err := ibctlrealtime.ApplyOverrides(ctx, mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
+		if err := ibctlrealtime.ApplyOverrides(ctx, container.Logger(), mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
 			return err
 		}
 	}

cmd/ibctl/internal/command/holding/holdingvalue/holdingvalue.go

@@ -131,7 +131,7 @@ func run(ctx context.Context, container appext.Container, flags *flags) error {
 	// Override market prices and FX rates with real-time data from Yahoo Finance.
 	if flags.Realtime {
 		todayDate := time.Now().Format("2006-01-02")
-		if err := ibctlrealtime.ApplyOverrides(ctx, mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
+		if err := ibctlrealtime.ApplyOverrides(ctx, container.Logger(), mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
 			return err
 		}
 	}

cmd/ibctl/internal/command/holding/lot/lotlist/lotlist.go

@@ -144,7 +144,7 @@ func run(ctx context.Context, container appext.Container, flags *flags) error {
 	// Override market prices and FX rates with real-time data from Yahoo Finance.
 	if flags.Realtime {
 		todayDate := time.Now().Format("2006-01-02")
-		if err := ibctlrealtime.ApplyOverrides(ctx, mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
+		if err := ibctlrealtime.ApplyOverrides(ctx, container.Logger(), mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
 			return err
 		}
 	}

internal/ibctl/ibctlrealtime/ibctlrealtime.go

@@ -15,6 +15,7 @@ package ibctlrealtime
 import (
 	"context"
 	"fmt"
+	"log/slog"
 
 	datav1 "github.com/bufdev/ibctl/internal/gen/proto/go/ibctl/data/v1"
 	"github.com/bufdev/ibctl/internal/ibctl/ibctlconfig"
@@ -27,6 +28,10 @@ import (
 // assetCategoryCash is the IBKR asset category for cash/FX positions.
 const assetCategoryCash = "CASH"
 
+// assetCategoryBond is the IBKR asset category for bond positions.
+// Yahoo Finance does not provide quotes for individual corporate bonds.
+const assetCategoryBond = "BOND"
+
 // RealTimeData holds real-time prices and FX rates fetched from Yahoo Finance.
 // All values are in micros (6 decimal places). This data is transient and not persisted.
 type RealTimeData struct {
@@ -42,14 +47,15 @@ type RealTimeData struct {
 // Returns an error if the API is unreachable or any symbol/FX pair cannot be resolved.
 func ApplyOverrides(
 	ctx context.Context,
+	logger *slog.Logger,
 	positions []*datav1.Position,
 	fxStore *ibctlfxrates.Store,
 	config *ibctlconfig.Config,
 	baseCurrency string,
 	todayDate string,
 ) error {
 	yahooClient := yahoofinance.NewClient()
-	realTimeData, err := FetchData(ctx, yahooClient, positions, config, baseCurrency)
+	realTimeData, err := FetchData(ctx, logger, yahooClient, positions, config, baseCurrency)
 	if err != nil {
 		return err
 	}
@@ -73,6 +79,7 @@ func ApplyOverrides(
 // resolved.
 func FetchData(
 	ctx context.Context,
+	logger *slog.Logger,
 	yahooClient yahoofinance.Client,
 	positions []*datav1.Position,
 	config *ibctlconfig.Config,
@@ -83,8 +90,10 @@ func FetchData(
 	ibkrToYahoo := make(map[string]string)
 	currencies := make(map[string]struct{})
 	for _, position := range positions {
-		// Skip cash positions — they have no equity quote.
-		if position.GetAssetCategory() == assetCategoryCash {
+		// Skip cash and bond positions — cash has no equity quote, and Yahoo Finance
+		// does not provide quotes for individual corporate bonds.
+		assetCategory := position.GetAssetCategory()
+		if assetCategory == assetCategoryCash || assetCategory == assetCategoryBond {
 			continue
 		}
 		ibkrSymbol := position.GetSymbol()
@@ -136,21 +145,31 @@ func FetchData(
 	for _, quote := range quotes {
 		yahooQuoteMap[quote.Symbol] = quote
 	}
-	// Verify all requested equity symbols were resolved and convert to micros.
+	// Convert resolved equity symbols to micros. Symbols not found on Yahoo Finance
+	// are skipped — positions without an override keep their cached IBKR price.
 	quoteMicros := make(map[string]int64, len(ibkrToYahoo))
 	for ibkrSymbol, yahooSymbol := range ibkrToYahoo {
 		quote, ok := yahooQuoteMap[yahooSymbol]
 		if !ok {
-			return nil, fmt.Errorf("symbol %q not found on Yahoo Finance (queried as %q), add a mapping under realtime_symbols in ibctl.yaml", ibkrSymbol, yahooSymbol)
+			logger.Warn("real-time quote not found, using cached price",
+				slog.String("symbol", ibkrSymbol),
+				slog.String("yahoo_symbol", yahooSymbol),
+			)
+			continue
 		}
 		quoteMicros[ibkrSymbol] = mathpb.ToMicros(quote.RegularMarketPrice)
 	}
-	// Verify all requested FX pairs were resolved and convert to micros.
+	// Convert resolved FX pairs to micros. Pairs not found on Yahoo Finance
+	// are skipped — the FX store falls back to its cached historical rate.
 	fxRateMicros := make(map[string]int64, len(fxYahooToPair))
 	for yahooFXSymbol, pairKey := range fxYahooToPair {
 		quote, ok := yahooQuoteMap[yahooFXSymbol]
 		if !ok {
-			return nil, fmt.Errorf("FX pair %q not found on Yahoo Finance (queried as %q)", pairKey, yahooFXSymbol)
+			logger.Warn("real-time FX rate not found, using cached rate",
+				slog.String("pair", pairKey),
+				slog.String("yahoo_symbol", yahooFXSymbol),
+			)
+			continue
 		}
 		fxRateMicros[pairKey] = mathpb.ToMicros(quote.RegularMarketPrice)
 	}

internal/ibctl/ibctltaxlot/ibctltaxlot.go

@@ -400,15 +400,24 @@ func VerifyPositions(computed []*datav1.ComputedPosition, reported []*datav1.Pos
 		key := lotKey{accountAlias: pos.GetAccountAlias(), symbol: pos.GetSymbol()}
 		computedMap[key] = pos
 	}
-	// Build a map of reported positions by (account_alias, symbol).
+	// Build a map of reported positions by (account_alias, symbol) and collect
+	// the set of IBKR account aliases. Non-IBKR accounts (e.g., manual additions)
+	// have no reported positions and are skipped during verification.
 	reportedMap := make(map[lotKey]*datav1.Position, len(reported))
+	ibkrAccounts := make(map[string]struct{})
 	for _, pos := range reported {
 		key := lotKey{accountAlias: pos.GetAccountAlias(), symbol: pos.GetSymbol()}
 		reportedMap[key] = pos
+		ibkrAccounts[pos.GetAccountAlias()] = struct{}{}
 	}
 	var discrepancies []PositionDiscrepancy
-	// Check computed positions against reported.
+	// Check computed positions against reported, skipping non-IBKR accounts.
 	for key, comp := range computedMap {
+		// Skip positions from non-IBKR accounts (e.g., manual additions) — there is
+		// nothing to verify them against.
+		if _, isIBKR := ibkrAccounts[key.accountAlias]; !isIBKR {
+			continue
+		}
 		rep, ok := reportedMap[key]
 		if !ok {
 			discrepancies = append(discrepancies, PositionDiscrepancy{

internal/pkg/yahoofinance/yahoofinance.go

@@ -82,11 +82,12 @@ func (c *client) GetQuotes(ctx context.Context, symbols []string) ([]Quote, erro
 		}()
 	}
 	waitGroup.Wait()
-	// Collect results, returning the first error encountered.
+	// Collect successful results. Per-symbol errors are skipped — the caller
+	// handles missing symbols via fallback to cached data.
 	quotes := make([]Quote, 0, len(symbols))
 	for _, r := range results {
 		if r.err != nil {
-			return nil, r.err
+			continue
 		}
 		quotes = append(quotes, r.quote)
 	}