Align all holding value labels to fixed column width

Author: bufdev

cmd/ibctl/internal/ibctlcmd/holdingsdata.go

@@ -303,35 +303,44 @@ func ComputeYTDTaxSummary(
 
 // WriteValueSummary writes the portfolio value summary with pregnant (unrealized) tax as formatted text.
 func WriteValueSummary(writer io.Writer, summary *ValueSummary, config *ibctlconfig.Config, formatBaseMicros func(int64) string) {
-	fmt.Fprintf(writer, "Portfolio Value:           %s\n", formatBaseMicros(summary.TotalValueMicros))
-	fmt.Fprintf(writer, "\n")
-	fmt.Fprintf(writer, "Pregnant STCG:             %s\n", formatBaseMicros(summary.TotalSTCGMicros))
-	fmt.Fprintf(writer, "Pregnant STCG Tax (%.1f%%): %s\n", config.TaxRateSTCG*100, formatBaseMicros(summary.STCGTaxMicros))
-	fmt.Fprintf(writer, "Pregnant LTCG:             %s\n", formatBaseMicros(summary.TotalLTCGMicros))
-	fmt.Fprintf(writer, "Pregnant LTCG Tax (%.1f%%): %s\n", config.TaxRateLTCG*100, formatBaseMicros(summary.LTCGTaxMicros))
-	fmt.Fprintf(writer, "Total Pregnant Tax:        %s\n", formatBaseMicros(summary.TotalTaxMicros))
+	writeValueLine(writer, "Portfolio Value", formatBaseMicros(summary.TotalValueMicros))
+	fmt.Fprintln(writer)
+	writeValueLine(writer, "Pregnant STCG", formatBaseMicros(summary.TotalSTCGMicros))
+	writeValueLine(writer, fmt.Sprintf("Pregnant STCG Tax (%.1f%%)", config.TaxRateSTCG*100), formatBaseMicros(summary.STCGTaxMicros))
+	writeValueLine(writer, "Pregnant LTCG", formatBaseMicros(summary.TotalLTCGMicros))
+	writeValueLine(writer, fmt.Sprintf("Pregnant LTCG Tax (%.1f%%)", config.TaxRateLTCG*100), formatBaseMicros(summary.LTCGTaxMicros))
+	writeValueLine(writer, "Total Pregnant Tax", formatBaseMicros(summary.TotalTaxMicros))
 }
 
 // WriteYTDTaxSummary writes the YTD realized income tax summary as formatted text.
 func WriteYTDTaxSummary(writer io.Writer, summary *YTDTaxSummary, config *ibctlconfig.Config, formatBaseMicros func(int64) string) {
-	fmt.Fprintf(writer, "YTD Realized Dividends:              %s\n", formatBaseMicros(summary.DividendMicros))
-	fmt.Fprintf(writer, "YTD Realized Dividend Tax (%.1f%%):  %s\n", config.TaxRateDividend*100, formatBaseMicros(summary.DividendTaxMicros))
-	fmt.Fprintf(writer, "YTD Realized Interest:               %s\n", formatBaseMicros(summary.InterestMicros))
-	fmt.Fprintf(writer, "YTD Realized Interest Tax (%.1f%%):  %s\n", config.TaxRateInterest*100, formatBaseMicros(summary.InterestTaxMicros))
-	fmt.Fprintf(writer, "YTD Realized STCG:                   %s\n", formatBaseMicros(summary.STCGMicros))
-	fmt.Fprintf(writer, "YTD Realized STCG Tax (%.1f%%):      %s\n", config.TaxRateSTCG*100, formatBaseMicros(summary.STCGTaxMicros))
-	fmt.Fprintf(writer, "YTD Realized LTCG:                   %s\n", formatBaseMicros(summary.LTCGMicros))
-	fmt.Fprintf(writer, "YTD Realized LTCG Tax (%.1f%%):      %s\n", config.TaxRateLTCG*100, formatBaseMicros(summary.LTCGTaxMicros))
-	fmt.Fprintf(writer, "YTD Realized Tax Owed:               %s\n", formatBaseMicros(summary.TotalTaxOwedMicros))
-	fmt.Fprintf(writer, "YTD Realized Tax Paid:               %s\n", formatBaseMicros(summary.TaxPaidMicros))
-	fmt.Fprintf(writer, "YTD Realized Tax Remaining:          %s\n", formatBaseMicros(summary.TaxRemainingMicros))
+	writeValueLine(writer, "YTD Realized Dividends", formatBaseMicros(summary.DividendMicros))
+	writeValueLine(writer, fmt.Sprintf("YTD Realized Dividend Tax (%.1f%%)", config.TaxRateDividend*100), formatBaseMicros(summary.DividendTaxMicros))
+	writeValueLine(writer, "YTD Realized Interest", formatBaseMicros(summary.InterestMicros))
+	writeValueLine(writer, fmt.Sprintf("YTD Realized Interest Tax (%.1f%%)", config.TaxRateInterest*100), formatBaseMicros(summary.InterestTaxMicros))
+	writeValueLine(writer, "YTD Realized STCG", formatBaseMicros(summary.STCGMicros))
+	writeValueLine(writer, fmt.Sprintf("YTD Realized STCG Tax (%.1f%%)", config.TaxRateSTCG*100), formatBaseMicros(summary.STCGTaxMicros))
+	writeValueLine(writer, "YTD Realized LTCG", formatBaseMicros(summary.LTCGMicros))
+	writeValueLine(writer, fmt.Sprintf("YTD Realized LTCG Tax (%.1f%%)", config.TaxRateLTCG*100), formatBaseMicros(summary.LTCGTaxMicros))
+	writeValueLine(writer, "YTD Realized Tax Owed", formatBaseMicros(summary.TotalTaxOwedMicros))
+	writeValueLine(writer, "YTD Realized Tax Paid", formatBaseMicros(summary.TaxPaidMicros))
+	writeValueLine(writer, "YTD Realized Tax Remaining", formatBaseMicros(summary.TaxRemainingMicros))
 }
 
 // WriteAfterTaxValue writes the combined after-tax portfolio value.
 // After-tax value = portfolio value - pregnant tax - YTD tax remaining.
 func WriteAfterTaxValue(writer io.Writer, valueSummary *ValueSummary, ytdSummary *YTDTaxSummary, formatBaseMicros func(int64) string) {
 	afterTaxMicros := valueSummary.TotalValueMicros - valueSummary.TotalTaxMicros - ytdSummary.TaxRemainingMicros
-	fmt.Fprintf(writer, "After-Tax Value:           %s\n", formatBaseMicros(afterTaxMicros))
+	writeValueLine(writer, "After-Tax Value", formatBaseMicros(afterTaxMicros))
+}
+
+// valueLabelWidth is the fixed column width for value summary labels, sized to accommodate
+// the longest label ("YTD Realized Dividend Tax (XX.X%)").
+const valueLabelWidth = 36
+
+// writeValueLine writes a single label-value line with consistent column alignment.
+func writeValueLine(writer io.Writer, label string, value string) {
+	fmt.Fprintf(writer, "%-*s %s\n", valueLabelWidth, label+":", value)
 }
 
 // WriteHoldingListTable writes the holding list as a table with securities,