Add YTD realized income tax section to holding value command

Author: bufdev

cmd/ibctl/internal/command/holding/holdingvalue/holdingvalue.go

@@ -8,24 +8,12 @@ package holdingvalue
 import (
 	"context"
 	"fmt"
-	"math"
 	"os"
-	"strings"
-	"time"
 
 	"buf.build/go/app/appcmd"
 	"buf.build/go/app/appext"
 	"github.com/bufdev/ibctl/cmd/ibctl/internal/ibctlcmd"
-	"github.com/bufdev/ibctl/internal/ibctl/ibctlconfig"
-	"github.com/bufdev/ibctl/internal/ibctl/ibctlfxrates"
 	"github.com/bufdev/ibctl/internal/ibctl/ibctlholdings"
-	"github.com/bufdev/ibctl/internal/ibctl/ibctlmerge"
-	"github.com/bufdev/ibctl/internal/ibctl/ibctlpath"
-	"github.com/bufdev/ibctl/internal/ibctl/ibctlrealtime"
-	"github.com/bufdev/ibctl/internal/pkg/cliio"
-	"github.com/bufdev/ibctl/internal/pkg/mathpb"
-	"github.com/bufdev/ibctl/internal/pkg/moneypb"
-	"github.com/bufdev/ibctl/internal/pkg/yahoofinance"
 	"github.com/spf13/pflag"
 )
 
@@ -94,93 +82,26 @@ func (f *flags) Bind(flagSet *pflag.FlagSet) {
 }
 
 func run(ctx context.Context, container appext.Container, flags *flags) error {
-	// Normalize base currency to uppercase for case-insensitive matching.
-	baseCurrency := strings.ToUpper(flags.BaseCurrency)
-	// Select the formatting function based on the base currency.
-	formatBaseMicros := formatBaseMicrosFunc(baseCurrency)
-	// Resolve the ibctl directory from the IBKR_DIR environment variable.
-	dirPath, err := ibctlcmd.DirPath(container)
+	// Load data through the common pipeline (config, merge, FX, optional download/realtime).
+	data, err := ibctlcmd.LoadHoldingsData(ctx, container, flags.Download, flags.Realtime, flags.BaseCurrency)
 	if err != nil {
 		return err
 	}
-	// Read and validate the configuration file from the base directory.
-	config, err := ibctlconfig.ReadConfig(dirPath)
+	// Compute holdings via FIFO from all trade data, converted to the base currency.
+	result, err := ibctlholdings.GetHoldingsOverview(data.MergedData.Trades, data.MergedData.Positions, data.MergedData.CashPositions, data.Config, data.FxStore, data.BaseCurrency)
 	if err != nil {
 		return err
 	}
-	// Download fresh data if --download is set.
-	if flags.Download {
-		downloader, err := ibctlcmd.NewDownloader(container, dirPath)
-		if err != nil {
-			return err
-		}
-		if err := downloader.Download(ctx); err != nil {
-			return err
-		}
-	}
-	// Merge trade data from all sources.
-	mergedData, err := ibctlmerge.Merge(
-		ibctlpath.DataAccountsDirPath(config.DirPath),
-		ibctlpath.CacheAccountsDirPath(config.DirPath),
-		ibctlpath.ActivityStatementsDirPath(config.DirPath),
-		ibctlpath.SeedDirPath(config.DirPath),
-		config.AccountAliases,
-		config.Additions,
-	)
+	formatBaseMicros := ibctlcmd.FormatBaseMicrosFunc(data.BaseCurrency)
+	// Compute and print the portfolio value summary with unrealized tax impact.
+	summary := ibctlcmd.ComputeValueSummary(result.Holdings, data.Config)
+	ibctlcmd.WriteValueSummary(os.Stdout, summary, data.Config, formatBaseMicros)
+	// Compute and print the YTD realized income tax summary.
+	ytdSummary, err := ibctlcmd.ComputeYTDTaxSummary(data.MergedData, data.Config, data.FxStore, data.BaseCurrency)
 	if err != nil {
 		return err
 	}
-	// Load FX rates for base currency conversion.
-	fxStore := ibctlfxrates.NewStore(ibctlpath.CacheFXDirPath(config.DirPath))
-	// Override market prices and FX rates with real-time data from Yahoo Finance.
-	if flags.Realtime {
-		todayDate := time.Now().Format("2006-01-02")
-		if err := ibctlrealtime.ApplyOverrides(ctx, container.Logger(), yahoofinance.NewClient(), mergedData.Positions, fxStore, config, baseCurrency, todayDate); err != nil {
-			return err
-		}
-	}
-	// Compute holdings via FIFO from all trade data, converted to the base currency.
-	result, err := ibctlholdings.GetHoldingsOverview(mergedData.Trades, mergedData.Positions, mergedData.CashPositions, config, fxStore, baseCurrency)
-	if err != nil {
-		return err
-	}
-	// Sum up portfolio value, STCG, and LTCG from all holdings in the base currency.
-	var totalValueMicros, totalSTCGMicros, totalLTCGMicros int64
-	for _, h := range result.Holdings {
-		totalValueMicros += mathpb.ParseMicros(h.MarketValueBase)
-		totalSTCGMicros += mathpb.ParseMicros(h.STCGBase)
-		totalLTCGMicros += mathpb.ParseMicros(h.LTCGBase)
-	}
-	// Compute tax amounts. Gains are taxed; losses reduce taxes (can be negative).
-	stcgTaxMicros := int64(math.Round(float64(totalSTCGMicros) * config.TaxRateSTCG))
-	ltcgTaxMicros := int64(math.Round(float64(totalLTCGMicros) * config.TaxRateLTCG))
-	totalTaxMicros := stcgTaxMicros + ltcgTaxMicros
-	// After-tax value = portfolio value - total taxes.
-	afterTaxMicros := totalValueMicros - totalTaxMicros
-	// Print the summary using the base currency formatting.
-	writer := os.Stdout
-	fmt.Fprintf(writer, "Portfolio Value:  %s\n", formatBaseMicros(totalValueMicros))
-	fmt.Fprintf(writer, "\n")
-	fmt.Fprintf(writer, "STCG:            %s\n", formatBaseMicros(totalSTCGMicros))
-	fmt.Fprintf(writer, "STCG Tax (%.1f%%):  %s\n", config.TaxRateSTCG*100, formatBaseMicros(stcgTaxMicros))
-	fmt.Fprintf(writer, "LTCG:            %s\n", formatBaseMicros(totalLTCGMicros))
-	fmt.Fprintf(writer, "LTCG Tax (%.1f%%):  %s\n", config.TaxRateLTCG*100, formatBaseMicros(ltcgTaxMicros))
-	fmt.Fprintf(writer, "Total Tax:       %s\n", formatBaseMicros(totalTaxMicros))
-	fmt.Fprintf(writer, "\n")
-	fmt.Fprintf(writer, "After-Tax Value: %s\n", formatBaseMicros(afterTaxMicros))
+	fmt.Fprintln(os.Stdout)
+	ibctlcmd.WriteYTDTaxSummary(os.Stdout, ytdSummary, data.Config, formatBaseMicros)
 	return nil
 }
-
-// formatBaseMicrosFunc returns a formatting function for micros values in the given currency.
-func formatBaseMicrosFunc(baseCurrency string) func(int64) string {
-	switch baseCurrency {
-	case "USD":
-		return cliio.FormatUSDMicros
-	case "CAD":
-		return cliio.FormatCADMicros
-	default:
-		return func(micros int64) string {
-			return moneypb.MoneyValueToString(moneypb.MoneyFromMicros(baseCurrency, micros))
-		}
-	}
-}