Description
PR #124 added 4 new MCP tools via LSP 3.17:
get_signature_helpgo_to_implementationgo_to_type_definitionget_inlay_hints
The ra_e2e test suite (ra_e2e_suite in tests/ra_e2e.rs) was not updated to cover these tools. It has 16 sub-cases for the original 16 tools. The comment at the top of the file still says "all 16 MCP tools" but there are now 20.
Additionally, test_e2e_list_tools in tests/e2e/protocol_tests.rs:
- Asserts
tools.len() == 20 (correct)
- Checks only 16 tool names by name in its
for expected in &[...] loop
- Does not verify
get_signature_help, go_to_implementation, go_to_type_definition, get_inlay_hints are present by name
Reproduction Steps
grep -c "sub_case!" crates/mcpls-core/tests/ra_e2e.rs
# output: 16
grep "get_signature_help\|go_to_implementation\|go_to_type_definition\|get_inlay_hints" crates/mcpls-core/tests/ra_e2e.rs
# no output
Expected Behavior
The ra_e2e suite should exercise all 20 tools against real rust-analyzer.
Actual Behavior
4 tools have no e2e coverage with real RA. Their LSP round-trip (position encoding, result translation, error handling) is unverified.
Environment
Description
PR #124 added 4 new MCP tools via LSP 3.17:
get_signature_helpgo_to_implementationgo_to_type_definitionget_inlay_hintsThe ra_e2e test suite (
ra_e2e_suiteintests/ra_e2e.rs) was not updated to cover these tools. It has 16 sub-cases for the original 16 tools. The comment at the top of the file still says "all 16 MCP tools" but there are now 20.Additionally,
test_e2e_list_toolsintests/e2e/protocol_tests.rs:tools.len() == 20(correct)for expected in &[...]loopget_signature_help,go_to_implementation,go_to_type_definition,get_inlay_hintsare present by nameReproduction Steps
Expected Behavior
The ra_e2e suite should exercise all 20 tools against real rust-analyzer.
Actual Behavior
4 tools have no e2e coverage with real RA. Their LSP round-trip (position encoding, result translation, error handling) is unverified.
Environment