Description
PR #124 added MCP resources support (LSP diagnostics exposed as MCP resources via lsp-diagnostics:// URIs). The McpClient test helper and the ra_e2e_suite do not exercise any of the four resource operations: list_resources, read_resource, subscribe, unsubscribe.
This means the entire resources feature path — `server.rs:list_resources`, `server.rs:read_resource`, `bridge/resources.rs`, push notification on diagnostics change — has no end-to-end test coverage.
Reproduction Steps
- Inspect
crates/mcpls-core/tests/e2e/mcp_client.rs — no list_resources or read_resource methods exist.
- Search
tests/ra_e2e.rs for "resources" — no hits.
- Run
cargo test --workspace --all-features --test ra_e2e -- --ignored — passes but never exercises resources.
Expected Behavior
ra_e2e_suite should include sub-cases that:
- Call
list_resources after opening a file and verify lsp-diagnostics:// URIs are returned.
- Call
read_resource with a valid URI and verify diagnostic content is returned.
- Call
subscribe and unsubscribe and verify no errors.
McpClient should grow list_resources() and read_resource(uri) helper methods.
Actual Behavior
None of the above is exercised. A bug in list_resources, read_resource, or the subscription pipeline would go undetected by the test suite.
Environment
- Version: HEAD 0f40608
- Features: all-features
Logs / Evidence
grep -n "list_resources\|read_resource" crates/mcpls-core/tests/e2e/mcp_client.rs → empty
grep -n "resources" crates/mcpls-core/tests/ra_e2e.rs → empty
Description
PR #124 added MCP resources support (LSP diagnostics exposed as MCP resources via
lsp-diagnostics://URIs). TheMcpClienttest helper and thera_e2e_suitedo not exercise any of the four resource operations:list_resources,read_resource,subscribe,unsubscribe.This means the entire resources feature path — `server.rs:list_resources`, `server.rs:read_resource`, `bridge/resources.rs`, push notification on diagnostics change — has no end-to-end test coverage.
Reproduction Steps
crates/mcpls-core/tests/e2e/mcp_client.rs— nolist_resourcesorread_resourcemethods exist.tests/ra_e2e.rsfor "resources" — no hits.cargo test --workspace --all-features --test ra_e2e -- --ignored— passes but never exercises resources.Expected Behavior
ra_e2e_suiteshould include sub-cases that:list_resourcesafter opening a file and verifylsp-diagnostics://URIs are returned.read_resourcewith a valid URI and verify diagnostic content is returned.subscribeandunsubscribeand verify no errors.McpClientshould growlist_resources()andread_resource(uri)helper methods.Actual Behavior
None of the above is exercised. A bug in
list_resources,read_resource, or the subscription pipeline would go undetected by the test suite.Environment
Logs / Evidence
grep -n "list_resources\|read_resource" crates/mcpls-core/tests/e2e/mcp_client.rs→ emptygrep -n "resources" crates/mcpls-core/tests/ra_e2e.rs→ empty