fix(test): add [workspace] table to rust_workspace fixture Cargo.toml#120
Merged
Conversation
Without [workspace], cargo treats the fixture as a member of the parent workspace (members = ["crates/*"]), which excludes it, causing rust-analyzer to emit "Failed to load workspaces." and 8 integration tests to return null/empty results. Closes #118
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[workspace]table tocrates/mcpls-core/tests/fixtures/rust_workspace/Cargo.tomlmembers = ["crates/*"]), which excludes the fixture path, causing rust-analyzer to emit "Failed to load workspaces."Test plan
cargo nextest run --workspace --all-features --lib --bins— all 345 tests passcargo nextest run --workspace --all-features --test integration_tests -- --ignoredwith rust-analyzer in PATH — 8 previously failing tests should now passCloses #118