Skip to content

perf(bridge): remove translator mutex from tool requests#181

Draft
vcheckk wants to merge 3 commits into
bug-ops:mainfrom
vcheckk:restart-issue-108
Draft

perf(bridge): remove translator mutex from tool requests#181
vcheckk wants to merge 3 commits into
bug-ops:mainfrom
vcheckk:restart-issue-108

Conversation

@vcheckk

@vcheckk vcheckk commented Jun 13, 2026

Copy link
Copy Markdown

Closes #108.

Stacking / readiness

What changed

  • Removes the outer translator mutex from MCP tool request handling so LSP requests do not serialize unrelated tools.
  • Moves runtime mutation behind narrower translator-owned locks, primarily the document tracker.

Validation

  • Branch-local cargo test -p mcpls-core passed.
  • Branch-local cargo clippy -p mcpls-core --all-targets -- -D warnings passed.
  • Included in standalone integration branch restart-standalone-integration.
  • Integration branch cargo test -p mcpls-core passed.
  • Integration branch cargo clippy -p mcpls-core --all-targets -- -D warnings passed.
  • Real rust-analyzer smoke passed on the integration branch: cargo test -p mcpls-core --test integration_tests integration::rust_analyzer_tests::test_hover_on_u64_type -- --ignored --exact --nocapture.

@github-actions github-actions Bot added rust Rust code changes testing Test-related changes mcpls-core mcpls-core crate changes labels Jun 13, 2026
@vcheckk

vcheckk commented Jun 13, 2026

Copy link
Copy Markdown
Author

Readiness note: keeping this PR as draft because the current branch is stacked on #180 / issue #104. It now passes local cargo test -p mcpls-core and cargo clippy -p mcpls-core --all-targets -- -D warnings, but it should either be reviewed after #180 or rebuilt/rebased once #180 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mcpls-core mcpls-core crate changes rust Rust code changes testing Test-related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(bridge): reduce Mutex<Translator> hold time — release lock before client.request()

1 participant