test(bridge): document lock-free translator context#182
Draft
vcheckk wants to merge 4 commits into
Draft
Conversation
Author
|
Readiness note: keeping this PR as draft because the current branch is stacked on #180 and #181 / issues #104 and #108. It now passes local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
Stacking / readiness
bug-ops/mcpls, I cannot set this PR's base to the fork branch used by perf(bridge): remove translator mutex from tool requests #181 in a way that GitHub will show as an upstream stacked PR.What changed
HandlerContextstoresArc<Translator>directly rather than an outer request-wide lock.Validation
cargo test -p mcpls-corepassed.cargo clippy -p mcpls-core --all-targets -- -D warningspassed.restart-standalone-integration.cargo test -p mcpls-corepassed.cargo clippy -p mcpls-core --all-targets -- -D warningspassed.cargo test -p mcpls-core --test integration_tests integration::rust_analyzer_tests::test_hover_on_u64_type -- --ignored --exact --nocapture.