Skip to content

Adds document_symbol support for pyrefly #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds document_symbol support for pyrefly #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ce6c0
Adds document_symbol support for pyrefly
jackd Mar 27, 2026
75b5d1b
Merge branch 'main' into pyrefly-document-symbol
jackd Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/mcpls-core/src/lsp/lifecycle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,11 @@ impl LspServer {
..Default::default()
}),
text_document: Some(lsp_types::TextDocumentClientCapabilities {
document_symbol: Some(lsp_types::DocumentSymbolClientCapabilities {
dynamic_registration: Some(false),

@bug-ops bug-ops May 24, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor consistency note: other capability blocks in this file declare symbol_kind.value_set explicitly. Not blocking, but worth aligning when convenient.

hierarchical_document_symbol_support: Some(true),
..Default::default()
}),
Comment on lines 293 to +298

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds document_symbol to the client capabilities, but there’s no test asserting that the initialize request includes this capability. Since this module already has unit tests, consider adding a small unit test (or factoring out capability construction) to prevent regressions where document_symbol support is accidentally dropped again.

Copilot uses AI. Check for mistakes.
hover: Some(lsp_types::HoverClientCapabilities {
dynamic_registration: Some(false),
content_format: Some(vec![
Expand Down
Loading