fix(acp): use file_path parameter for mcpls tool calls (#1539)

* fix(acp): use file_path parameter for mcpls tool calls

McpLspProvider was sending "uri" as the parameter key for all mcpls
tool invocations, but mcpls 0.3.4 expects "file_path". Fixes all
six affected methods: hover, definition, references, diagnostics,
document_symbols, and code_actions.

Also fix code_actions to send flat start_line/start_character/end_line/
end_character instead of a nested range object, matching the mcpls
get_code_actions tool schema.

Closes #1533

* docs(changelog): add entry for #1533 acp lsp param fix

Author: bug-ops

CHANGELOG.md

@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ### Fixed
 
+- `McpLspProvider` was sending `"uri"` as the parameter key to all mcpls tool calls, but mcpls 0.3.4 expects `"file_path"`. All six methods (`hover`, `definition`, `references`, `diagnostics`, `document_symbols`, `code_actions`) are fixed. `code_actions` additionally now sends flat `start_line`/`start_character`/`end_line`/`end_character` fields instead of a nested `range` object, matching the mcpls `get_code_actions` schema. Fixes #1533.
 - `--init` wizard generated unsupported `--workspace-root` flag for mcpls. The wizard now writes `.zeph/mcpls.toml` (with workspace roots, language extensions, and rust-analyzer LSP server config) and passes `--config .zeph/mcpls.toml` to mcpls instead. Fixes broken LSP setup for all users who configured mcpls via `zeph init`. (#1534)
 - Shell command blocklist (`blocked_commands`, `DEFAULT_BLOCKED`, `allow_network = false`) was silently skipped whenever a `PermissionPolicy` was attached to `ShellExecutor` (i.e., in all normal operation with `autonomy_level` set). `find_blocked_command()` now runs unconditionally before the policy check, making it a hard security boundary that cannot be bypassed by any autonomy level or permission policy configuration.
 

crates/zeph-acp/src/lsp/mcp_provider.rs

@@ -107,7 +107,7 @@ impl LspProvider for McpLspProvider {
         line: u32,
         character: u32,
     ) -> Result<LspHoverResult, AcpError> {
-        let args = serde_json::json!({ "uri": uri, "line": line, "character": character });
+        let args = serde_json::json!({ "file_path": uri, "line": line, "character": character });
         self.call_tool("get_hover", args).await.and_then(|v| {
             serde_json::from_value(v).map_err(|e| AcpError::ClientError(e.to_string()))
         })
@@ -119,7 +119,7 @@ impl LspProvider for McpLspProvider {
         line: u32,
         character: u32,
     ) -> Result<Vec<LspLocation>, AcpError> {
-        let args = serde_json::json!({ "uri": uri, "line": line, "character": character });
+        let args = serde_json::json!({ "file_path": uri, "line": line, "character": character });
         self.call_tool("get_definition", args).await.and_then(|v| {
             serde_json::from_value(v).map_err(|e| AcpError::ClientError(e.to_string()))
         })
@@ -133,7 +133,7 @@ impl LspProvider for McpLspProvider {
         include_declaration: bool,
     ) -> Result<Vec<LspLocation>, AcpError> {
         let args = serde_json::json!({
-            "uri": uri,
+            "file_path": uri,
             "line": line,
             "character": character,
             "include_declaration": include_declaration,
@@ -147,14 +147,14 @@ impl LspProvider for McpLspProvider {
     }
 
     async fn diagnostics(&self, uri: &str) -> Result<Vec<LspDiagnostic>, AcpError> {
-        let args = serde_json::json!({ "uri": uri });
+        let args = serde_json::json!({ "file_path": uri });
         self.call_tool("get_diagnostics", args).await.and_then(|v| {
             serde_json::from_value(v).map_err(|e| AcpError::ClientError(e.to_string()))
         })
     }
 
     async fn document_symbols(&self, uri: &str) -> Result<Vec<LspDocumentSymbol>, AcpError> {
-        let args = serde_json::json!({ "uri": uri });
+        let args = serde_json::json!({ "file_path": uri });
         self.call_tool("get_document_symbols", args)
             .await
             .and_then(|v| {
@@ -178,12 +178,14 @@ impl LspProvider for McpLspProvider {
         &self,
         uri: &str,
         range: &LspRange,
-        diagnostics: &[LspDiagnostic],
+        _diagnostics: &[LspDiagnostic],
     ) -> Result<Vec<LspCodeAction>, AcpError> {
         let args = serde_json::json!({
-            "uri": uri,
-            "range": range,
-            "diagnostics": diagnostics,
+            "file_path": uri,
+            "start_line": range.start.line,
+            "start_character": range.start.character,
+            "end_line": range.end.line,
+            "end_character": range.end.character,
         });
         let value = self.call_tool("get_code_actions", args).await?;
         let actions: Vec<LspCodeAction> =