Skip to content

Commit 14ba3e6

Browse files
committed
#200: fixed flickering test
1 parent 8b258cb commit 14ba3e6

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

src/communications/alerts_service.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import logging
2+
from collections import OrderedDict
23

34
from communications import destination_base
45
from communications.communicaton_service import CommunicationsService
@@ -49,7 +50,7 @@ def __init__(self, params_dict):
4950
self._destination = http.HttpDestination(params_dict)
5051

5152
def send(self, title, body, files=None):
52-
data = {'title': title, 'message': body}
53+
data = OrderedDict([('title', title), ('message', body)])
5354

5455
self._destination.send(title, data, files=files)
5556

src/tests/alerts_service_test.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import json
33
import sys
44
import unittest
5+
from collections import OrderedDict
56
from unittest import mock
67

78
from communications import alerts_service
@@ -138,12 +139,12 @@ def test_send_http_alert(self):
138139

139140
self.send_alert(alerts_service, body, files, title)
140141

141-
expected_body = json.dumps({
142-
'title': title,
143-
'message': body,
144-
'files': {
142+
expected_body = json.dumps(OrderedDict([
143+
('title', title),
144+
('message', body),
145+
('files', {
145146
'log.txt': 'doing X'
146-
}})
147+
})]))
147148
self.assertEqual([(None, expected_body, None)], self.get_communicators()[0].messages)
148149

149150
def test_import_alerts_service_with_missing_dependencies(self):

0 commit comments

Comments
 (0)