#339 fixed missing logs when opening a new script-view for existing executor

Author: bugy

web-src/src/main-app/components/scripts/script-view.vue

@@ -17,7 +17,7 @@
                     'red lighten-1': !killEnabled,
                     'grey darken-4': killEnabled}"
                     @click="stopScript">
-                {{stopButtonLabel}}
+                {{ stopButtonLabel }}
             </button>
             <div class="button-gap" v-if="schedulable"></div>
             <ScheduleButton :disabled="!enableScheduleButton" @click="openSchedule" v-if="schedulable"/>
@@ -347,23 +347,32 @@
             },
 
             logChunks: {
+                immediate: true,
                 handler(newValue, oldValue) {
-                    if (isNull(newValue)) {
-                        this.setLog('');
-                        this.nextLogIndex = 0;
+                    const updateLog = () => {
+                        if (isNull(newValue)) {
+                            this.setLog('');
+                            this.nextLogIndex = 0;
 
-                        return;
-                    }
+                            return;
+                        }
 
-                    if (newValue !== oldValue) {
-                        this.setLog('');
-                        this.nextLogIndex = 0;
-                    }
+                        if (newValue !== oldValue) {
+                            this.setLog('');
+                            this.nextLogIndex = 0;
+                        }
+
+                        for (; this.nextLogIndex < newValue.length; this.nextLogIndex++) {
+                            const logChunk = newValue[this.nextLogIndex];
 
-                    for (; this.nextLogIndex < newValue.length; this.nextLogIndex++) {
-                        const logChunk = newValue[this.nextLogIndex];
+                            this.appendLog(logChunk);
+                        }
+                    }
 
-                        this.appendLog(logChunk);
+                    if (isNull(this.$refs.logPanel)) {
+                        this.$nextTick(updateLog);
+                    } else {
+                        updateLog();
                     }
                 }
             },

web-src/tests/unit/main-app/components/scripts/script-view_test.js

@@ -0,0 +1,91 @@
+'use strict';
+import ScriptView from '@/main-app/components/scripts/script-view';
+import {createLocalVue, mount} from '@vue/test-utils';
+import Vuex from 'vuex';
+
+const localVue = createLocalVue();
+localVue.use(Vuex);
+
+
+describe('Test ScriptView', function () {
+    let scriptView;
+    let store;
+
+    beforeEach(async function () {
+        store = new Vuex.Store({
+            modules: {
+                scripts: {
+                    namespaced: true,
+                    state: {
+                        selectedScript: 'abc'
+                    }
+                },
+                scriptConfig: {
+                    namespaced: true,
+                    state: {
+                        scriptConfig: {
+                            description: ''
+                        },
+                        loading: false
+                    }
+                },
+                executions: {
+                    namespaced: true,
+                    state: {
+                        currentExecutor: null,
+                        executors: {}
+                    },
+                    actions: {
+                        selectExecutor({state}, executor) {
+                            state.currentExecutor = executor;
+                        }
+                    }
+                }
+            }
+        });
+
+        scriptView = mount(ScriptView, {
+            attachToDocument: true,
+            store,
+            localVue
+        });
+
+        scriptView.vm.$parent.$forceUpdate();
+        await scriptView.vm.$nextTick();
+    });
+
+    afterEach(function () {
+        scriptView.destroy();
+    });
+
+    describe('Test log content', function () {
+        it('test init with logs', async function () {
+            store.state.executions.currentExecutor = {
+                state: {
+                    id: 1,
+                    scriptName: 'my script',
+                    logChunks: ['a', 'b', 'c'],
+                    inputPromptText: '',
+                    inlineImages: {}
+                }
+            };
+
+            const newScriptView = mount(ScriptView, {
+                attachToDocument: true,
+                store,
+                localVue
+            });
+
+            newScriptView.vm.$parent.$forceUpdate();
+            await newScriptView.vm.$nextTick();
+
+            try {
+                const logText = newScriptView.get('.log-content').text();
+                expect(logText).toEqual('abc');
+
+            } finally {
+                newScriptView.destroy();
+            }
+        });
+    });
+});