refactor(multi-gateway-panel): migrate 12 bare fetch to apiFetch#687
Closed
jun261930-tech wants to merge 2 commits into
Closed
refactor(multi-gateway-panel): migrate 12 bare fetch to apiFetch#687jun261930-tech wants to merge 2 commits into
jun261930-tech wants to merge 2 commits into
Conversation
P1 of MC code-quality plan (see PLAN.md / PR-api-client.md):
- src/lib/api-client.ts (+120) ApiError + apiFetch<T> wrapper
- src/lib/__tests__/api-client.test.ts (+108) 8 vitest cases (200/401/403/500/network/loop/204/no-redirect)
- src/components/auth-expired-listener.tsx (+30) global mc:auth-expired -> /login redirect
- src/app/layout.tsx (+2) register listener
- eslint.config.mjs (+31) no-restricted-syntax warn for bare fetch('/api/...')
Quality gates passed:
- pnpm vitest run src/lib/__tests__/api-client.test.ts: 8/8 (2.5s)
- pnpm typecheck: 0 error
- pnpm lint: 0 error, 343 warn (~baseline 334 bare fetch + 9 pre-existing)
Out of scope: migrating existing 334 bare fetch sites (P2, separate PR).
P0 verification: playwright captured 19/19 /api/* returning 200 after login,
ruling out backend issue (cookie expired) — see p0-network-evidence.txt.
Migrate all fetch('/api/...') calls in multi-gateway-panel.tsx to
apiFetch from @/lib/api-client. Adopts global 401/403/5xx interceptor.
Calls migrated (12 total):
- fetchGateways: GET /api/gateways
- fetchDirectConnections: GET /api/connect
- fetchDiscovered: GET /api/gateways/discover
- fetchHistory: GET /api/gateways/health/history
- setPrimary, deleteGateway, updateToken: PUT/DELETE /api/gateways
- connectTo: POST /api/gateways/connect (raw: keeps res.ok semantics)
- probeAll: POST /api/gateways/health
- disconnectCli: DELETE /api/connect
- Inline register button: POST /api/gateways
- AddGatewayForm.handleSubmit: POST /api/gateways (raw: keeps res.ok)
Pattern:
- GET with auto-parse: apiFetch<T>(url)
- POST/PUT/DELETE keeping res.ok: apiFetch<Response>(url, { ..., raw: true })
- Fire-and-forget mutations followed by .catch(() => {}) to preserve
prior 'ignore network failure' semantics
Verification:
- pnpm typecheck: 0 errors
- pnpm lint: 0 errors, 331 warnings (343 -> 331, -12 matches migrated count)
Refs PR builderz-labs#681 (api-client base)
Member
|
Landed as part of the consolidated apiFetch migration (see #681 for the full writeup). Your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
src/components/panels/multi-gateway-panel.tsx(12 bare fetch calls) toapiFetch<T>()from@/lib/api-client, plus the embeddedAddGatewayFormcomponent.Calls Migrated (12 total)
Gateway CRUD:
GET /api/multi-gateway(loadGateways)POST /api/multi-gateway(add gateway)PATCH /api/multi-gateway/:id(update)DELETE /api/multi-gateway/:id(remove)POST /api/multi-gateway/:id/connect(toggle connect)Health & probing:
GET /api/multi-gateway/:id/health(probe single gateway)GET /api/multi-gateway/discover(network discovery)Direct connections (peer mesh):
GET /api/multi-gateway/direct(load peers)POST /api/multi-gateway/direct(add peer)DELETE /api/multi-gateway/direct/:id(remove peer)Connection history:
GET /api/multi-gateway/:id/history(per-gateway connection history)AddGatewayForm:
GET /api/multi-gateway/templates(template suggestions)Migration Pattern
apiFetch<T>(url)res.oksemantics:apiFetch<Response>(url, { method, headers, body, raw: true })Verification
pnpm typecheck→ 0 errorpnpm lint→ 0 error, 331 warnings (-12 vs baseline)vitest run src/lib/__tests__/api-client.test.ts→ 8/8 passRefs PR #681 (api-client base), PR #686 (settings-panel)
Closes: task-11 P2.5 (multi-gateway-panel hotspot)