I would like to suggest a method name change.
I found the naming of broken_hard_limits_for confusing. I could not understand what was "broken" about these set of limits. I believe the intent of this methods is to get limits that have been violated, or infringed upon. If this is the case I would like to propose a change from broken_hard_limits_for to violated_hard_limits_for.
IMHO it more clearly speaks to the intent.
I would like to suggest a method name change.
I found the naming of
broken_hard_limits_forconfusing. I could not understand what was "broken" about these set of limits. I believe the intent of this methods is to get limits that have been violated, or infringed upon. If this is the case I would like to propose a change frombroken_hard_limits_fortoviolated_hard_limits_for.IMHO it more clearly speaks to the intent.