Merge branch 'master' into fix_mark_for_chekbox_parent

harshad1 · web-flow · commit 722432962781 · 2025-12-06T01:22:50.000-08:00
diff --git a/README.md b/README.md
@@ -107,10 +107,34 @@ let g:bullets_custom_mappings = [
   \ ]
 ```
 
-Enable/disable deleting the last empty bullet when hitting `<cr>` (insert mode) or `o` (normal mode):
+Enable/disable deleting or promoting the last empty bullet when hitting `<cr>` (insert mode) or `o` (normal mode):
 
 ```vim
-let g:bullets_delete_last_bullet_if_empty = 0 " default = 1
+" Example (| is cursor):
+" - text
+"   - text
+"   - |
+
+let g:bullets_delete_last_bullet_if_empty = 1 " default = 1
+" - text
+"   - text
+" |
+
+let g:bullets_delete_last_bullet_if_empty = 0
+" - text
+"   - text
+"   - 
+"   |
+
+let g:bullets_delete_last_bullet_if_empty = 2
+" - text
+"   - text
+" - |
+"
+" again:
+" - text
+"   - text
+" |
 ```
 
 Line spacing between bullets (1 = no blank lines, 2 = one blank line, etc.):
@@ -295,7 +319,7 @@ let g:bullets_checkbox_partials_toggle = 0
 * Promote a bullet (unindent it and increase the bullet level):
   + NORMAL mode: `<<`
   + INSERT mode: `<C-d>`
-  + VISUAL mode: `>`
+  + VISUAL mode: `<`
 
 Disable default mappings:
 
diff --git a/doc/bullets.txt b/doc/bullets.txt
@@ -83,6 +83,11 @@ GENERAL COMMANDS                            *bullets-commands*
                        A blank line before/after the first/last bullet denotes
                        the end of the list.
 
+                                            *bullets-:RecomputeCheckboxes*
+:RecomputeCheckboxes   Recomputes all partial checkboxes in the current list.
+                       Preserves state for all checkboxes with no children and
+                       recomputes all checkboxes up to the top of the list.
+
                                             *bullets-:BulletDemote*
 :BulletDemote          Demotes the current bullet by indenting it and changing
                        its bullet type to the next level defined in 
@@ -148,7 +153,7 @@ To add a leader key to all mappings set the following:
 This will set the <space> key as leader to all default mappings.
 
 
-Disabling empty bullet deletion
+Empty bullet deletion
 -------------------------------
 By default bullets.vim will delete trailing empty bullets when the return key
 is pressed, just like modern word processors.
@@ -157,6 +162,10 @@ If you would like to turn this feature off add the following to your .vimrc
 
   `let g:bullets_delete_last_bullet_if_empty = 0`
 
+If you would like to promote bullet instead of deleting it, add the following to your .vimrc
+
+  `let g:bullets_delete_last_bullet_if_empty = 2`
+
 
 Maintain right padding on bullets
 ---------------------------------
diff --git a/plugin/bullets.vim b/plugin/bullets.vim
@@ -161,7 +161,7 @@ fun! s:parse_bullet_text(line_text)
   if s:bullet_cache isnot v:null
     let l:cached = get(s:bullet_cache, a:line_text, v:null)
     if l:cached isnot v:null
-      " Return a copy so as not to break the referene
+      " Return a copy so as not to break the reference
       return copy(l:cached)
     endif
   endif
@@ -177,11 +177,11 @@ fun! s:parse_bullet_text(line_text)
   let l:roman = empty(l:bullet) && empty(l:num) ? s:match_roman_list_item(a:line_text) : {}
 
   let l:kinds = s:filter([l:bullet, l:check, l:num, l:alpha, l:roman], '!empty(v:val)')
-  
+
   if s:bullet_cache isnot v:null
     let s:bullet_cache[a:line_text] = l:kinds
   endif
-    
+
   return l:kinds
 endfun
 
@@ -574,7 +574,11 @@ fun! s:insert_new_bullet()
       " We don't want to create a new bullet if the previous one was not used,
       " instead we want to delete the empty bullet - like word processors do
       if g:bullets_delete_last_bullet_if_empty
-        call setline(l:curr_line_num, '')
+        if g:bullets_delete_last_bullet_if_empty == 1
+          call setline(l:curr_line_num, '')
+        elseif g:bullets_delete_last_bullet_if_empty == 2
+          call <SID>change_bullet_level(1, 0)
+        endif
         let l:send_return = 0
       endif
     elseif !(l:bullet.bullet_type ==# 'abc' && s:abc2dec(l:bullet.bullet) + 1 > s:abc_max)
@@ -775,6 +779,85 @@ fun! s:set_child_checkboxes(lnum, checked)
   endif
 endfun
 
+" Recompute partial checkboxes of a full checkbox tree given the root lnum
+fun! s:recompute_checkbox_tree(lnum)
+  if !g:bullets_nested_checkboxes
+    return
+  endif
+
+  let l:indent = indent(a:lnum)
+  let l:bullet = s:closest_bullet_types(a:lnum, l:indent)
+  let l:bullet = s:resolve_bullet_type(l:bullet)
+
+  if l:bullet.bullet_type !=# 'chk'
+    return
+  endif
+
+  " recursively recompute checkbox tree for all children, then finally self
+
+  let l:children = s:get_children_line_numbers(a:lnum)
+  for l:child_nr in l:children
+    " nb: this skips 'grandchildren' checkboxes (i.e., children who aren't
+    " checkboxes but have checkbox children themselves), but those grandkids
+    " will be targeted by s:recompute_checkboxes_in_range anyway
+    call s:recompute_checkbox_tree(l:child_nr)
+  endfor
+
+
+  if empty(l:children)
+    " if no children, preserve previous checked state
+    " partially completed checkboxes become unchecked
+    if empty(l:bullet) || !has_key(l:bullet, 'checkbox_marker')
+      return
+    endif
+
+    let l:checkbox_markers = split(g:bullets_checkbox_markers, '\zs')
+    let l:partial_markers = join(l:checkbox_markers[1:-2], '')
+
+    if l:bullet.checkbox_marker =~# '\v[' . l:partial_markers . ']'
+      call s:set_checkbox(a:lnum, l:checkbox_markers[0])
+    endif
+  else
+    " if children exist, recompute this checkbox status
+    let l:first_child = l:children[0]
+    let l:completion_marker = s:sibling_checkbox_status(l:first_child)
+    call s:set_checkbox(a:lnum, l:completion_marker)
+  endif
+endfun
+
+fun! s:recompute_checkboxes_in_range(start, end)
+  if !g:bullets_nested_checkboxes
+    return
+  endif
+
+  call s:enable_bullet_cache()
+  for l:nr in range(a:start, a:end)
+    " find all bullets who do not have a checkbox parent
+    let l:parent = s:get_parent(l:nr)
+    if !empty(l:parent) && l:parent.bullet_type ==# 'chk'
+      continue
+    end
+
+    call s:recompute_checkbox_tree(l:nr)
+  endfor
+  call s:disable_bullet_cache()
+endfun
+
+" Recomputes checkboxes for the whole list containing the cursor.
+fun! s:recompute_checkboxes()
+  if !g:bullets_nested_checkboxes
+    return
+  endif
+
+  call s:enable_bullet_cache()
+  let l:first_line = s:first_bullet_line(line('.'))
+  let l:last_line = s:last_bullet_line(line('.'))
+  if l:first_line > 0 && l:last_line > 0
+    call s:recompute_checkboxes_in_range(l:first_line, l:last_line)
+  endif
+  call s:disable_bullet_cache()
+endfun
+
 command! SelectCheckboxInside call <SID>select_checkbox(1)
 command! SelectCheckbox call <SID>select_checkbox(0)
 command! ToggleCheckbox call <SID>toggle_checkboxes_nested()
@@ -957,6 +1040,7 @@ endfun
 
 command! -range=% RenumberSelection call <SID>renumber_selection()
 command! RenumberList call <SID>renumber_whole_list()
+command! RecomputeCheckboxes call <SID>recompute_checkboxes()
 
 " --------------------------------------------------------- }}}
 
@@ -967,7 +1051,7 @@ fun! s:change_line_bullet_level(direction, lnum)
   if a:direction == 1
     if l:curr_line != [] && indent(a:lnum) == 0
       " Promoting a bullet at the highest level will delete the bullet
-      call setline(a:lnum, l:curr_line[0].text_after_bullet)
+      call setline(a:lnum, l:curr_line[-1].text_after_bullet)
       return
     else
       execute a:lnum . 'normal! <<'
@@ -1103,6 +1187,9 @@ nnoremap <silent> <Plug>(bullets-renumber) :RenumberList<cr>
 " Toggle checkbox
 nnoremap <silent> <Plug>(bullets-toggle-checkbox) :ToggleCheckbox<cr>
 
+" Recompute checkbox list
+nnoremap <silent> <Plug>(bullets-recompute-checkboxes) :RecomputeCheckboxes<cr>
+
 " Promote and Demote outline level
 inoremap <silent> <Plug>(bullets-demote) <C-o>:BulletDemote<cr>
 nnoremap <silent> <Plug>(bullets-demote) :BulletDemote<cr>
diff --git a/spec/bullets_spec.rb b/spec/bullets_spec.rb
@@ -271,6 +271,31 @@
         TEXT
       end
 
+      it 'promote the last bullet when configured to' do
+        filename = "#{SecureRandom.hex(6)}.txt"
+        write_file(filename, <<-TEXT)
+          # Hello there
+          - this is the first bullet
+            - this is the second bullet
+        TEXT
+
+        vim.command 'let g:bullets_delete_last_bullet_if_empty = 2'
+        vim.edit filename
+        vim.type 'GA'
+        vim.feedkeys '\<cr>'
+        vim.feedkeys '\<cr>'
+        vim.write
+
+        file_contents = IO.read(filename)
+
+        expect(file_contents.strip).to eq normalize_string_indent(<<-TEXT)
+          # Hello there
+          - this is the first bullet
+            - this is the second bullet
+          -
+        TEXT
+      end
+
       it 'does not delete the last bullet when configured not to' do
         filename = "#{SecureRandom.hex(6)}.txt"
         write_file(filename, <<-TEXT)
diff --git a/spec/checkboxes_spec.rb b/spec/checkboxes_spec.rb
@@ -248,4 +248,139 @@
 
     TEXT
   end
+
+  it 'recomputes checkboxes recursively on RecomputeCheckboxes' do
+    filename = "#{SecureRandom.hex(6)}.txt"
+    write_file(filename, <<-TEXT)
+      # Hello there
+      - [ ] EXPECTED: ¼
+        - [X] checkbox leaf
+        - [ ] EXPECTED: CHECKED
+          - [ ] EXPECTED: CHECKED
+            - [ ] EXPECTED: CHECKED
+              - [X] checkbox leaf
+          - [X] checkbox leaf
+        - [X] EXPECTED: ¾
+          - [X] checkbox leaf
+          - [X] checkbox leaf
+          - [X] checkbox leaf
+          - [ ] checkbox leaf
+        - [X] EXPECTED: ½
+          - [ ] EXPECTED: CHECKED
+            - [ ] EXPECTED: CHECKED
+              - [X] checkbox leaf
+          - [½] checkbox leaf (EXPECTED: UNCHECKED)
+        - [½] EXPECTED: UNCHECKED
+          - [ ] checkbox leaf
+          - [½] checkbox leaf (EXPECTED: UNCHECKED)
+    TEXT
+
+    vim.edit filename
+    vim.command 'let g:bullets_checkbox_markers=" .¼½¾X"'
+    vim.type '9j'
+    vim.command 'RecomputeCheckboxes'
+    vim.write
+
+    file_contents = IO.read(filename)
+
+    expect(file_contents).to eq normalize_string_indent(<<-TEXT)
+      # Hello there
+      - [¼] EXPECTED: ¼
+        - [X] checkbox leaf
+        - [X] EXPECTED: CHECKED
+          - [X] EXPECTED: CHECKED
+            - [X] EXPECTED: CHECKED
+              - [X] checkbox leaf
+          - [X] checkbox leaf
+        - [¾] EXPECTED: ¾
+          - [X] checkbox leaf
+          - [X] checkbox leaf
+          - [X] checkbox leaf
+          - [ ] checkbox leaf
+        - [½] EXPECTED: ½
+          - [X] EXPECTED: CHECKED
+            - [X] EXPECTED: CHECKED
+              - [X] checkbox leaf
+          - [ ] checkbox leaf (EXPECTED: UNCHECKED)
+        - [ ] EXPECTED: UNCHECKED
+          - [ ] checkbox leaf
+          - [ ] checkbox leaf (EXPECTED: UNCHECKED)
+
+    TEXT
+  end
+
+  it 'recomputes checkboxes correctly on reindents' do
+    filename = "#{SecureRandom.hex(6)}.txt"
+    write_file(filename, <<-TEXT)
+      # Hello there
+      - [X] parent bullet
+        - [X] first child bullet
+    TEXT
+
+    vim.edit filename
+    vim.command 'let g:bullets_checkbox_markers=" /X"'
+    vim.type 'GA'
+    vim.feedkeys '\<cr>'
+    vim.command 'RecomputeCheckboxes'
+    vim.write
+
+    file_contents = IO.read(filename)
+
+    expect(file_contents).to eq normalize_string_indent(<<-TEXT)
+      # Hello there
+      - [/] parent bullet
+        - [X] first child bullet
+        - [ ] 
+
+    TEXT
+
+    vim.command 'let g:bullets_delete_last_bullet_if_empty = 2'
+    vim.feedkeys '\<cr>'
+    vim.command 'RecomputeCheckboxes'
+    vim.write
+
+    file_contents = IO.read(filename)
+
+    expect(file_contents).to eq normalize_string_indent(<<-TEXT)
+      # Hello there
+      - [X] parent bullet
+        - [X] first child bullet
+      - [ ] 
+
+    TEXT
+  end
+
+  it 'handles skip-level checkbox trees' do
+    filename = "#{SecureRandom.hex(6)}.txt"
+    write_file(filename, <<-TEXT)
+      # Hello there
+      - [X] parent bullet (EXPECTED: /)
+        - skip: not checkbox content
+          - [ ] new root bullet (EXPECTED: /)
+            - [ ] first child bullet
+            - [X] first child bullet
+        - [X] first child bullet
+        - [ ] first child bullet
+    TEXT
+
+    vim.edit filename
+    vim.command 'let g:bullets_checkbox_markers=" /X"'
+    vim.type '2j'
+    vim.command 'RecomputeCheckboxes'
+    vim.write
+
+    file_contents = IO.read(filename)
+
+    expect(file_contents).to eq normalize_string_indent(<<-TEXT)
+      # Hello there
+      - [/] parent bullet (EXPECTED: /)
+        - skip: not checkbox content
+          - [/] new root bullet (EXPECTED: /)
+            - [ ] first child bullet
+            - [X] first child bullet
+        - [X] first child bullet
+        - [ ] first child bullet
+
+    TEXT
+  end
 end
