Skip to content

Add missing Parcelable to InsideTheBackStack.NavTarget and IndexedBackStack.State #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LissF wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Add missing Parcelable to InsideTheBackStack.NavTarget and IndexedBackStack.State #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion samples/app/src/main/kotlin/com/bumble/appyx/app/node/backstack/InsideTheBackStack.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.bumble.appyx.app.node.backstack

import android.os.Parcelable
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
Expand Down Expand Up @@ -30,6 +31,7 @@ import com.bumble.appyx.core.node.Node
import com.bumble.appyx.core.node.ParentNode
import kotlinx.coroutines.delay
import kotlinx.coroutines.isActive
import kotlinx.parcelize.Parcelize

class InsideTheBackStack(
buildContext: BuildContext,
Expand Down Expand Up @@ -61,7 +63,8 @@ class InsideTheBackStack(
}
}

sealed class NavTarget {
sealed class NavTarget : Parcelable {
@Parcelize
data class Child(val index: Int) : NavTarget() {
override fun toString(): String = index.toString()
}
Expand Down
12 changes: 10 additions & 2 deletions .../main/kotlin/com/bumble/appyx/app/node/backstack/app/indexedbackstack/IndexedBackStack.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package com.bumble.appyx.app.node.backstack.app.indexedbackstack

import android.os.Parcelable
import com.bumble.appyx.core.navigation.BaseNavModel
import com.bumble.appyx.core.navigation.NavElements
import com.bumble.appyx.core.navigation.NavKey
import com.bumble.appyx.core.navigation.Operation
import com.bumble.appyx.core.state.SavedStateMap
import kotlinx.parcelize.Parcelize

class IndexedBackStack<NavTarget : Any>(
savedState: SavedStateMap?,
Expand All @@ -15,14 +17,20 @@ class IndexedBackStack<NavTarget : Any>(
savedStateMap = savedState
) {

sealed interface State {
sealed interface State : Parcelable {
@Parcelize
object Created : State

@Parcelize
object Active : State
class Stashed(

@Parcelize
data class Stashed(
val index: Int,
val size: Int
) : State

@Parcelize
object Destroyed : State
}

Expand Down