Skip to content

Replace mcp_server by mcp-server in API urls #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fbraure wants to merge 1 commit into from
Closed

Replace mcp_server by mcp-server in API urls #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class BumpApi {
body: WorkflowVersionRequest,
token: string,
): Promise<AxiosResponse<WorkflowVersionResponse>> =>
this.client.post<WorkflowVersionResponse>(`/mcp_servers/${mcpServerIdOrSlug}/deploy`, body, {
this.client.post<WorkflowVersionResponse>(`/mcp-servers/${mcpServerIdOrSlug}/deploy`, body, {
headers: this.authorizationHeader(token),
})

Expand Down
6 changes: 3 additions & 3 deletions test/commands/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import {API} from '../../src/definition'

nock.disableNetConnect()

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node latest - x64 on ubuntu-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 23 - x64 on ubuntu-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 20 - x64 on ubuntu-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 23 - x64 on windows-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node latest - x64 on windows-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 20 - x64 on windows-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node latest - x64 on macos-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 20 - x64 on macos-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

Check warning on line 8 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 23 - x64 on macos-latest 

Caution: `nock` also has a named export `disableNetConnect`. Check if you meant to write `import {disableNetConnect} from 'nock'` instead

process.env.BUMP_TOKEN = process.env.BUMP_TOKEN || 'BAR'

Expand Down Expand Up @@ -92,7 +92,7 @@

it("doesn't try to auto create a documentation", async () => {
nock('https://bump.sh')
.post('/api/v1/validations', (body) => !body.auto_create_documentation)

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node latest - x64 on ubuntu-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 23 - x64 on ubuntu-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 20 - x64 on ubuntu-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 23 - x64 on windows-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node latest - x64 on windows-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 20 - x64 on windows-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node latest - x64 on macos-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 20 - x64 on macos-latest 

Too many nested callbacks (5). Maximum allowed is 4

Check warning on line 95 in test/commands/deploy.test.ts

View workflow job for this annotation

GitHub Actions / Node 23 - x64 on macos-latest 

Too many nested callbacks (5). Maximum allowed is 4
.reply(200)

await runCommand(
Expand All @@ -113,7 +113,7 @@

describe('Successful runs with MCP server', () => {
it('sends new workflow definition (flower) to Bump', async () => {
nock('https://bump.sh').post('/api/v1/mcp_servers/crab/deploy').reply(201, {})
nock('https://bump.sh').post('/api/v1/mcp-servers/crab/deploy').reply(201, {})

const {stderr, stdout} = await runCommand(
['deploy', 'examples/valid/flower/parking.yml', '--mcp-server', 'crab'].join(' '),
Expand All @@ -130,7 +130,7 @@
await API.load('examples/valid/arazzo/wikimedia.json')
).extractDefinition()
nock('https://bump.sh')
.post('/api/v1/mcp_servers/crab/deploy', (body) => {
.post('/api/v1/mcp-servers/crab/deploy', (body) => {
const {content: expectedContent, location: expectedLocation, name: expectedName} = references[0]
const {content: actualContent, location: actualLocation, name: actualName} = body.references[0]
return (
Expand All @@ -153,7 +153,7 @@
})

it('sends unchanged workflow definition to Bump', async () => {
nock('https://bump.sh').post('/api/v1/mcp_servers/crab/deploy').reply(204)
nock('https://bump.sh').post('/api/v1/mcp-servers/crab/deploy').reply(204)

const {stderr, stdout} = await runCommand(
['deploy', 'examples/valid/flower/parking.yml', '--mcp-server', 'crab'].join(' '),
Expand Down
Loading