bump Node to 20.x and actions/* to v4#223
Merged
Merged
Conversation
Floating-dependency installs are now pulling transitive deps that require Node 20+ (mktemp@2.0.2, modern execa). The 14.x and 16.x runners installed the wrong CJS/ESM mix and failed every job. Bump all three jobs to Node 20.x (current LTS), and update actions/checkout and actions/setup-node to v4 since v3 is deprecated as of 2024.
@ember/string@4.x removed htmlSafe; it has been canonically exported from @ember/template since Ember 3.x. The old @ember/string import path now throws "htmlSafe is not implemented in the @ember/string package. Please import from @ember/template instead." under modern @ember/string.
lukemelia
changed the title
lukemelia
added a commit
that referenced
this pull request
Apr 19, 2026
CI was moved to Node 20.x in #223 after Node 14/16 broke on modern transitive deps (mktemp, execa). Align the advertised engines range and the volta-pinned dev version to match so contributors and consumers get Node 20.x too.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related bumps to get CI green:
1. Node + actions bumps (commit 1)
Floating-dependency installs now pull transitive deps that require Node 20+ (
mktemp@2.0.2, modernexeca), and the 14.x / 16.x CI runners fail every job with either:or:
All three jobs (
test,floating,try-scenarios) bumped to Node 20.x (current LTS).actions/checkoutandactions/setup-nodebumped from v3 to v4 (v3 has been deprecated since 2024).2.
htmlSafeimport path (commit 2)After the Node bump, the
floatingand older-Ember scenarios surfaced a separate failure:@ember/string@4.xremovedhtmlSafe(it has been canonically exported from@ember/templatesince Ember 3.x). Single import site fixed inaddon/components/tether-to-selection/component.js.Test plan
actions/checkoutandactions/setup-nodereferences are v4.htmlSafeimports from@ember/string.embroider-safehas a separate preexisting'VERSION' (imported as 'MOBILEDOC_KIT_VERSION') was not found in 'mobiledoc-kit'regression that is out of scope here).🤖 Generated with Claude Code