Bump engines.node and volta.node to Node 20#224
Merged
Conversation
CI was moved to Node 20.x in #223 after Node 14/16 broke on modern transitive deps (mktemp, execa). Align the advertised engines range and the volta-pinned dev version to match so contributors and consumers get Node 20.x too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #223. CI is on Node 20.x, but
package.jsonstill advertisesengines.node: 12.* || 14.* || >= 16and pinsvolta.node: 12.22.12for contributors — both versions that CI just proved don't work against modern transitive deps (mktemp,execa).engines.node:12.* || 14.* || >= 16→>= 20volta.node:12.22.12→20.19.1(matches CI)volta.yarn: unchangedTest plan
engines.nodeandvolta.nodematch CI.🤖 Generated with Claude Code