Add ember-try scenarios for Ember 4.12 LTS, 5.12 LTS, and 6.12#226
Merged
Conversation
ember-lts-4.12: installs cleanly with just an ember-source override; tests green locally. ember-lts-5.12 and ember-6.12: marked allowedToFail. They need more overrides (@ember/string@^4, ember-resolver@^13) and a build-infra refresh (dummy app initializers + webpack) before they can pass. Worth running in CI now so future regressions surface early even if fixing them is a separate effort. Also add ember-lts-4.4 to the CI try-scenarios matrix — previously defined in config but not actually exercised by CI.
Signals intent without misleading readers into thinking the addon is compatible with Ember 5.12 / 6.12 at these points.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three new
ember-tryscenarios and wires them into CI:ember-lts-4.12ember-source: ~4.12.0ember-lts-5.12-failingember-source,@ember/string@^4,ember-resolver@^13allowedToFail— needs build-infra refreshember-6.12-failingember-source,@ember/string@^4,ember-resolver@^13allowedToFail— needs build-infra refreshThe 5.12 and 6.12 scenarios carry the
-failingsuffix so GitHub viewers don't infer Ember 5/6 compatibility from a passing-looking badge. They run in CI and will flip to the unsuffixed names once the addon is actually compatible.Also adds
ember-lts-4.4to the CI matrix — previously defined inconfig/ember-try.jsbut not actually exercised by the workflow.Local verification
ember try:one ember-lts-4.12→ all scenarios succeeded.Why
allowedToFailon 5.12 and 6.12Under Ember 5+,
@ember/stringis no longer bundled withember-source— it needs an explicit dependency. With that plus a currentember-resolver, the scenarios install, but the dummy app's build config still produces a runtimeTypeError: Cannot read properties of undefined (reading 'classify')in an auto-registered initializer DAG — a sign that the test-harness plumbing (dummy app initializer wiring, webpack config) needs a refresh beyond what anember-tryscenario override can do.Rather than block this PR on that refresh, the scenarios run as
allowedToFailso CI surfaces regressions early. Fixing the infrastructure is worth its own PR.Test plan
ember-lts-4.12passes locally.ember-lts-5.12-failingandember-6.12-failinginstall under the scenario overrides (install succeeds; runtime still fails).allowedToFailones may be red but don't gate.🤖 Generated with Claude Code