From 075ab029b6c037602b2651adc6fbcaec9240abc1 Mon Sep 17 00:00:00 2001 From: Luke Melia Date: Sun, 19 Apr 2026 10:10:44 -0400 Subject: [PATCH 1/2] Add ember-lts-4.12, ember-lts-5.12, and ember-6.12 try scenarios MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ember-lts-4.12: installs cleanly with just an ember-source override; tests green locally. ember-lts-5.12 and ember-6.12: marked allowedToFail. They need more overrides (@ember/string@^4, ember-resolver@^13) and a build-infra refresh (dummy app initializers + webpack) before they can pass. Worth running in CI now so future regressions surface early even if fixing them is a separate effort. Also add ember-lts-4.4 to the CI try-scenarios matrix — previously defined in config but not actually exercised by CI. --- .github/workflows/ci.yml | 4 ++++ config/ember-try.js | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8b6a4c3..2992ae8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,6 +61,10 @@ jobs: try-scenario: - ember-lts-3.24 - ember-lts-3.28 + - ember-lts-4.4 + - ember-lts-4.12 + - ember-lts-5.12 + - ember-6.12 - ember-classic - embroider-safe - embroider-optimized diff --git a/config/ember-try.js b/config/ember-try.js index e285f0d..565a898 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -37,6 +37,41 @@ module.exports = async function () { }, }, }, + { + name: 'ember-lts-4.12', + npm: { + devDependencies: { + 'ember-source': '~4.12.0', + }, + }, + }, + { + // Needs a build-infrastructure refresh (dummy app initializer wiring + // + webpack config) before it can pass. Surfacing regressions here + // is still useful — allowedToFail so CI doesn't block on it. + name: 'ember-lts-5.12', + npm: { + devDependencies: { + '@ember/string': '^4.0.0', + 'ember-source': '~5.12.0', + 'ember-resolver': '^13.0.0', + }, + }, + allowedToFail: true, + }, + { + // Same story as ember-lts-5.12 — build infrastructure needs a + // refresh before this can pass cleanly. + name: 'ember-6.12', + npm: { + devDependencies: { + '@ember/string': '^4.0.0', + 'ember-source': '~6.12.0', + 'ember-resolver': '^13.0.0', + }, + }, + allowedToFail: true, + }, { name: 'ember-classic', env: { From 6d0e7e3c779d7228b523b881bec81f30ec651a0e Mon Sep 17 00:00:00 2001 From: Luke Melia Date: Sun, 19 Apr 2026 10:31:34 -0400 Subject: [PATCH 2/2] Rename the not-yet-passing scenarios with -failing suffix Signals intent without misleading readers into thinking the addon is compatible with Ember 5.12 / 6.12 at these points. --- .github/workflows/ci.yml | 4 ++-- config/ember-try.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2992ae8..3336d1d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -63,8 +63,8 @@ jobs: - ember-lts-3.28 - ember-lts-4.4 - ember-lts-4.12 - - ember-lts-5.12 - - ember-6.12 + - ember-lts-5.12-failing + - ember-6.12-failing - ember-classic - embroider-safe - embroider-optimized diff --git a/config/ember-try.js b/config/ember-try.js index 565a898..d95fd10 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -49,7 +49,7 @@ module.exports = async function () { // Needs a build-infrastructure refresh (dummy app initializer wiring // + webpack config) before it can pass. Surfacing regressions here // is still useful — allowedToFail so CI doesn't block on it. - name: 'ember-lts-5.12', + name: 'ember-lts-5.12-failing', npm: { devDependencies: { '@ember/string': '^4.0.0', @@ -62,7 +62,7 @@ module.exports = async function () { { // Same story as ember-lts-5.12 — build infrastructure needs a // refresh before this can pass cleanly. - name: 'ember-6.12', + name: 'ember-6.12-failing', npm: { devDependencies: { '@ember/string': '^4.0.0',