👷 Add ty to precommit (fastapilabs#167)

* add ty to precommit

* fixes

* add ignore

* exclude tests/assets for ty as well

* add three more ignores

---------

Co-authored-by: Patrick Arminio <patrick.arminio@gmail.com>

Author: svlandeg

.pre-commit-config.yaml

@@ -33,3 +33,10 @@ repos:
         require_serial: true
         language: unsupported
         pass_filenames: false
+
+      - id: local-ty
+        name: ty check
+        entry: uv run ty check src tests
+        require_serial: true
+        language: unsupported
+        pass_filenames: false

pyproject.toml

@@ -52,6 +52,7 @@ dev = [
     "ruff==0.13.0",
     "respx==0.22.0",
     "time-machine==2.15.0",
+    "ty>=0.0.9",
 ]
 
 [project.urls]
@@ -103,6 +104,9 @@ show_contexts = true
 strict = true
 exclude = ["tests/assets/*"]
 
+[tool.ty.src]
+exclude = ["tests/assets/**"]
+
 [tool.ruff.lint]
 select = [
     "E",  # pycodestyle errors

scripts/lint.sh

@@ -4,5 +4,6 @@ set -e
 set -x
 
 mypy src tests
+ty check src tests
 ruff check src tests scripts
 ruff format src tests --check

src/fastapi_cloud_cli/commands/deploy.py

@@ -478,7 +478,7 @@ def _wait_for_deployment(
                     time_elapsed = time.monotonic() - started_at
 
                     if log.type == "message":
-                        progress.log(Text.from_ansi(log.message.rstrip()))
+                        progress.log(Text.from_ansi(log.message.rstrip()))  # ty: ignore[unresolved-attribute]
 
                     if log.type == "complete":
                         build_complete = True
@@ -581,13 +581,13 @@ def _waitlist_form(toolkit: RichToolkit) -> None:
         )
         form.add_input("secret_code", label="Secret code", placeholder="123456")
 
-        result = form.run()  # type: ignore
+        result = form.run()  # type: ignore  # ty: ignore[unused-ignore-comment]
 
         try:
             result = SignupToWaitingList.model_validate(
                 {
                     "email": email,
-                    **result,  # type: ignore
+                    **result,  # type: ignore  # ty: ignore[unused-ignore-comment]
                 },
             )
         except ValidationError:

tests/test_api_client.py

@@ -55,10 +55,10 @@ def test_stream_build_logs_successful(
     assert len(logs) == 3
 
     assert logs[0].type == "message"
-    assert logs[0].message == "Building..."
+    assert logs[0].message == "Building..."  # ty: ignore[unresolved-attribute]
 
     assert logs[1].type == "message"
-    assert logs[1].message == "Done!"
+    assert logs[1].message == "Done!"  # ty: ignore[unresolved-attribute]
 
     assert logs[2].type == "complete"
 
@@ -201,7 +201,7 @@ def test_stream_build_logs_network_error_retry(
 
     assert len(logs) == 2
     assert logs[0].type == "message"
-    assert logs[0].message == "Success after retry"
+    assert logs[0].message == "Success after retry"  # ty: ignore[unresolved-attribute]
 
 
 def test_stream_build_logs_server_error_retry(