Trim code: remove unused functions, inline simple logic, simplify timeframe options

Author: buzzkillb

bot.py

@@ -62,11 +62,6 @@ def load_bot_configs() -> list[BotConfig]:
 DISPLAY_NAME_MAP = {}
 
 
-def get_display_name(crypto: str) -> str:
-    """Get display name for a ticker, using shorter aliases where defined."""
-    return DISPLAY_NAME_MAP.get(crypto.upper(), crypto.upper())
-
-
 def format_price(price: float) -> str:
     """Format price for display."""
     if price >= 1000:
@@ -77,13 +72,6 @@ def format_price(price: float) -> str:
         return f"${price:.6f}"
 
 
-def calculate_change_percent(current: float, previous: float) -> float:
-    """Calculate percentage change."""
-    if previous <= 0:
-        return 0.0
-    return ((current - previous) / previous) * 100
-
-
 class PriceBot(discord.Client):
     def __init__(
         self,
@@ -121,32 +109,22 @@ async def get_1h_change(self, crypto: str) -> float:
             if len(history) >= 2:
                 oldest = history[0][1]
                 newest = history[-1][1]
-                return calculate_change_percent(newest, oldest)
+                if oldest > 0:
+                    return ((newest - oldest) / oldest) * 100
         except Exception as e:
             logger.debug(f"Could not get 1h change for {crypto}: {e}")
         return 0.0
 
     async def get_price_for_crypto(self, crypto: str) -> Optional[float]:
-        """Get price, using database fallback for SSILVER."""
+        """Get price, using database fallback if fetch fails."""
         price = await self.price_service.get_price(crypto)
-
-        if price is None or price <= 0:
-            db_price = await self.db.get_latest_price(crypto)
-            if db_price and db_price > 0:
-                logger.debug(f"Using cached {crypto} price: ${db_price}")
-                return db_price
-            return None
-
-        if crypto == "SSILVER" and price < 10:
-            db_price = await self.db.get_latest_price(crypto)
-            if db_price and db_price > 10:
-                logger.debug(
-                    f"SSILVER: Live price {price} seems low, using cached: ${db_price}"
-                )
-                return db_price
-            logger.warning(f"SSILVER: Price {price} below threshold, using anyway")
-
-        return price
+        if price and price > 0:
+            return price
+        db_price = await self.db.get_latest_price(crypto)
+        if db_price and db_price > 0:
+            logger.debug(f"Using cached {crypto} price: ${db_price}")
+            return db_price
+        return None
 
     async def get_conversion_prices(self) -> dict:
         """Get BTC, ETH, SOL prices for conversion."""
@@ -179,7 +157,7 @@ async def update_discord_presence(
                 return
 
             formatted_price = format_price(price)
-            nickname = f"{get_display_name(display_crypto)} {formatted_price}"
+            nickname = f"{display_crypto.upper()} {formatted_price}"
 
             # Cycle through: BTC value, ETH value, SOL value, 1h%
             tickers = ["BTC", "ETH", "SOL"]
@@ -258,44 +236,16 @@ async def update_loop():
 
 
 class ChartGroup(app_commands.Group):
-    TIMEFRAME_OPTIONS = {
+    TIMEFRAMES = {
         "1h": 1,
-        "1hr": 1,
-        "1hour": 1,
         "6h": 6,
-        "6hr": 6,
-        "6hour": 6,
         "12h": 12,
-        "12hr": 12,
-        "12hour": 12,
         "24h": 24,
-        "1d": 24,
-        "24hr": 24,
-        "1day": 24,
-        "48h": 48,
         "2d": 48,
-        "48hr": 48,
-        "2day": 48,
-        "168h": 168,
-        "7d": 168,
         "1w": 168,
-        "1wk": 168,
-        "1week": 168,
-        "336h": 336,
-        "14d": 336,
         "2w": 336,
-        "2wk": 336,
-        "2week": 336,
-        "720h": 720,
         "30d": 720,
-        "30day": 720,
-        "1m": 720,
-        "1month": 720,
-        "2160h": 2160,
-        "90d": 2160,
         "3m": 2160,
-        "3month": 2160,
-        "90day": 2160,
     }
 
     def __init__(self, db: Database, chart_service: ChartService, crypto_name: str):
@@ -308,10 +258,10 @@ def __init__(self, db: Database, chart_service: ChartService, crypto_name: str):
     @app_commands.describe(timeframe="Timeframe (e.g., 24h, 2d, 1w, 30d, 3m)")
     async def price(self, interaction: discord.Interaction, timeframe: str = "24h"):
         """Generate price chart."""
-        hours = self.TIMEFRAME_OPTIONS.get(timeframe.lower())
+        hours = self.TIMEFRAMES.get(timeframe.lower())
         if not hours:
             await interaction.response.send_message(
-                f"Invalid timeframe '{timeframe}'. Try: 24h, 2d, 1w, 30d, 3m",
+                f"Invalid timeframe. Try: {', '.join(self.TIMEFRAMES.keys())}",
                 ephemeral=True,
             )
             return
@@ -321,7 +271,7 @@ async def price(self, interaction: discord.Interaction, timeframe: str = "24h"):
     async def timeframe_autocomplete(
         self, interaction: discord.Interaction, current: str
     ):
-        options = list(self.TIMEFRAME_OPTIONS.keys())
+        options = list(self.TIMEFRAMES.keys())
         filtered = (
             [opt for opt in options if current.lower() in opt.lower()]
             if current