Fix TS na Vitest issues#477
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Andarist
commented
May 1, 2025
Contributor
Author
There was a problem hiding this comment.
it ends up being easier to handle this with a dedicated Vitest config so a single config doesn't have to pretend to be a server at times and then to be a browser at different times.
Andarist
commented
May 1, 2025
Andarist
commented
May 1, 2025
| }); | ||
|
|
||
| test("should throw if default size is less than 0 or greater than 100", () => { | ||
| test.skip("should throw if default size is less than 0 or greater than 100", () => { |
Contributor
Author
There was a problem hiding this comment.
this runs into some infinite loop or smth and makes the test hang - I'm still investigating what's up with this
Contributor
Author
There was a problem hiding this comment.
Ok, so this version pass:
test("should throw if default size is less than 0 or greater than 100", () => {
expectWarning(
"Invalid layout total size: -1%. Layout normalization will be applied."
);
expectWarning("default size should not be less than 0");
act(() => {
root.render(
<PanelGroup direction="horizontal">
<Panel defaultSize={-1} />
</PanelGroup>
);
});
act(() => {
root.render(
<PanelGroup direction="horizontal">
<Panel defaultSize={101} />
</PanelGroup>
);
});
});but clearly it doesn't do what the test title says. So something is off here and has to be fixed - I'll leave that to you ;p
Owner
There was a problem hiding this comment.
Works for me when I uncommented the skip 🤷🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on top of #476