Add worker-related conditions#479
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Andarist
commented
May 2, 2025
Comment on lines
+23
to
+25
| "edge-light": "./dist/react-resizable-panels.development.edge-light.js", | ||
| "worker": "./dist/react-resizable-panels.development.edge-light.js", | ||
| "workerd": "./dist/react-resizable-panels.development.edge-light.js", |
Contributor
Author
There was a problem hiding this comment.
Notice those are the same as the one for node - the bundle itself is reused. Those keys here are just listed in order of preference (remember those keys here are ordered - despite being just object keys)
bvaughn
approved these changes
May 3, 2025
Owner
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
"workerd" 😮💨 Whew, the JS toolchain can be exhausting sometimes
Owner
|
Published in 3.0.1 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve support for Cloudflare Workers and Vercel Functions. Bundlers for workers often, annoyingly, prefer
browserconditions over node/default - so when we include a browser condition, we, almost always, have to specify the worker conditions first in the context of React.