Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Replace `"unset"` styles with safer override values
- Use capture phase for `"pointerdown"` and `"pointerup"` events; this is necessary for compatibility with certain UI libraries like Blueprint JS

## 4.3.0

Expand Down
12 changes: 8 additions & 4 deletions lib/global/mountGroup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ export function mountGroup(group: RegisteredGroup) {

// If this is the first group to be mounted, initialize event handlers
if (ownerDocumentReferenceCounts.get(ownerDocument) === 1) {
ownerDocument.addEventListener("pointerdown", onDocumentPointerDown);
ownerDocument.addEventListener("pointerdown", onDocumentPointerDown, true);
ownerDocument.addEventListener("pointerleave", onDocumentPointerLeave);
ownerDocument.addEventListener("pointermove", onDocumentPointerMove);
ownerDocument.addEventListener("pointerup", onDocumentPointerUp);
ownerDocument.addEventListener("pointerup", onDocumentPointerUp, true);
}

return function unmountGroup() {
Expand All @@ -197,10 +197,14 @@ export function mountGroup(group: RegisteredGroup) {

// If this was the last group to be mounted, tear down event handlers
if (!ownerDocumentReferenceCounts.get(ownerDocument)) {
ownerDocument.removeEventListener("pointerdown", onDocumentPointerDown);
ownerDocument.removeEventListener(
"pointerdown",
onDocumentPointerDown,
true
);
ownerDocument.removeEventListener("pointerleave", onDocumentPointerLeave);
ownerDocument.removeEventListener("pointermove", onDocumentPointerMove);
ownerDocument.removeEventListener("pointerup", onDocumentPointerUp);
ownerDocument.removeEventListener("pointerup", onDocumentPointerUp, true);
}

resizeObserver.disconnect();
Expand Down
Loading