Skip to content

Commit 201e688

Browse files
committed
Moved scroll-event blocking code into AutoSizer since its more relevant there
1 parent 7507f10 commit 201e688

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

source/AutoSizer/AutoSizer.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export default class AutoSizer extends Component {
4141
}
4242

4343
this._onResize = this._onResize.bind(this)
44+
this._onScroll = this._onScroll.bind(this)
4445
this._setRef = this._setRef.bind(this)
4546
}
4647

@@ -77,6 +78,7 @@ export default class AutoSizer extends Component {
7778
return (
7879
<div
7980
ref={this._setRef}
81+
onScroll={this._onScroll}
8082
style={outerStyle}
8183
>
8284
{children({ height, width })}
@@ -102,6 +104,11 @@ export default class AutoSizer extends Component {
102104
onResize({ height, width })
103105
}
104106

107+
_onScroll (event) {
108+
// Prevent detectElementResize library from being triggered by this scroll event.
109+
event.stopPropagation()
110+
}
111+
105112
_setRef (autoSizer) {
106113
// In case the component has been unmounted
107114
this._parentNode = autoSizer && autoSizer.parentNode

source/Grid/Grid.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -732,9 +732,6 @@ export default class Grid extends Component {
732732
return
733733
}
734734

735-
// Prevent detectElementResize library from being triggered by this scroll event.
736-
event.stopPropagation()
737-
738735
// Prevent pointer events from interrupting a smooth scroll
739736
this._enablePointerEventsAfterDelay()
740737

0 commit comments

Comments
 (0)