Skip to content

Commit 2e308ed

Browse files
committed
Built 5.5.3
1 parent 6aefc0f commit 2e308ed

6 files changed

Lines changed: 31 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Changelog
22
------------
33

4+
##### 5.5.3
5+
Added `will-change` property to `Grid` to work around a Chrome bug(?) that caused the entire grid to be repainted whenever a new row or column was added. This was negatively impacting scrolling performance for Chrome under certain conditions. This change is not expected to impact Firefox, Safari, or IE.
6+
7+
Also trapped scroll events inside of `AutoSizer` so that `sdecima/javascript-detect-element-resize` did not treat them as potential resizes and unnecessarily force a sync DOM layout.
8+
49
##### 5.5.2
510
Removed two unnecessary method calls in `Grid` and replaced them with cached properties. Should offer a minor performance boost.
611
Added better bounds-checking to util function `getVisibleCellIndices()`

dist/commonjs/AutoSizer/AutoSizer.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ var AutoSizer = function (_Component) {
4545
};
4646

4747
_this._onResize = _this._onResize.bind(_this);
48+
_this._onScroll = _this._onScroll.bind(_this);
4849
_this._setRef = _this._setRef.bind(_this);
4950
return _this;
5051
}
@@ -93,6 +94,7 @@ var AutoSizer = function (_Component) {
9394
'div',
9495
{
9596
ref: this._setRef,
97+
onScroll: this._onScroll,
9698
style: outerStyle
9799
},
98100
children({ height: height, width: width })
@@ -122,6 +124,12 @@ var AutoSizer = function (_Component) {
122124

123125
onResize({ height: height, width: width });
124126
}
127+
}, {
128+
key: '_onScroll',
129+
value: function _onScroll(event) {
130+
// Prevent detectElementResize library from being triggered by this scroll event.
131+
event.stopPropagation();
132+
}
125133
}, {
126134
key: '_setRef',
127135
value: function _setRef(autoSizer) {

dist/es/AutoSizer/AutoSizer.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ var AutoSizer = function (_Component) {
2525
};
2626

2727
_this._onResize = _this._onResize.bind(_this);
28+
_this._onScroll = _this._onScroll.bind(_this);
2829
_this._setRef = _this._setRef.bind(_this);
2930
return _this;
3031
}
@@ -73,6 +74,7 @@ var AutoSizer = function (_Component) {
7374
'div',
7475
{
7576
ref: this._setRef,
77+
onScroll: this._onScroll,
7678
style: outerStyle
7779
},
7880
children({ height: height, width: width })
@@ -102,6 +104,12 @@ var AutoSizer = function (_Component) {
102104

103105
onResize({ height: height, width: width });
104106
}
107+
}, {
108+
key: '_onScroll',
109+
value: function _onScroll(event) {
110+
// Prevent detectElementResize library from being triggered by this scroll event.
111+
event.stopPropagation();
112+
}
105113
}, {
106114
key: '_setRef',
107115
value: function _setRef(autoSizer) {

dist/umd/react-virtualized.js

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/umd/react-virtualized.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "React components for efficiently rendering large, scrollable lists and tabular data",
44
"author": "Brian Vaughn <brian.david.vaughn@gmail.com>",
55
"user": "bvaughn",
6-
"version": "5.5.2",
6+
"version": "5.5.3",
77
"homepage": "https://github.com/bvaughn/react-virtualized",
88
"main": "dist/commonjs/index.js",
99
"jsnext:main": "dist/es/index.js",

0 commit comments

Comments
 (0)