Skip to content

Commit 0ec8321

Browse files
committed
dotcode: Apply upper bounds to rows and columns options
1 parent 019509e commit 0ec8321

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

src/dotcode.ps.src

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,14 +305,14 @@ begin
305305
(input.validate) //dotcode.before exec
306306

307307
rows -1 ne {
308-
rows 5 lt {
309-
/bwipp.dotcodeBadRows (There must be at least 5 rows) //raiseerror exec
308+
rows 5 lt rows 200 gt or {
309+
/bwipp.dotcodeBadRows (Rows must be from 5 to 200) //raiseerror exec
310310
} if
311311
} if
312312

313313
columns -1 ne {
314-
columns 5 lt {
315-
/bwipp.dotcodeBadColumns (There must be at least 5 columns) //raiseerror exec
314+
columns 5 lt columns 200 gt or {
315+
/bwipp.dotcodeBadColumns (Columns must be from 5 to 200) //raiseerror exec
316316
} if
317317
} if
318318

tests/ps_tests/dotcode.ps.test

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,13 @@
161161
% Error tests
162162
%
163163

164-
% Invalid rows (valid: 5+)
164+
% Invalid rows (valid: 5 to 200)
165165
(TEST) (rows=4 dontdraw) /bwipp.dotcodeBadRows er_tmpl
166+
(TEST) (rows=201 dontdraw) /bwipp.dotcodeBadRows er_tmpl
166167

167-
% Invalid columns (valid: 5+)
168+
% Invalid columns (valid: 5 to 200)
168169
(TEST) (columns=4 dontdraw) /bwipp.dotcodeBadColumns er_tmpl
170+
(TEST) (columns=201 dontdraw) /bwipp.dotcodeBadColumns er_tmpl
169171

170172
% Rows + columns must be odd
171173
(TEST) (rows=6 columns=6 dontdraw) /bwipp.dotcodeRowsColumnsBadParity er_tmpl

0 commit comments

Comments
 (0)