gs1process: Avoid inefficient AI parsing

Author: terryburton

src/gs1-cc.ps.src

@@ -243,6 +243,10 @@ begin
         } if
     } if
 
+    barcode length 10000 gt {  % (90) + numeric capacity (2372) at 4:1 ^NNN parse expansion
+        /bwipp.gs1ccinputTooLong (The input data is too long) //raiseerror exec
+    } if
+
     barcode /ai //gs1process exec
     /fncs exch def
     /vals exch def

src/gs1northamericancoupon.ps.src

@@ -100,6 +100,10 @@ begin
 
     /barcode exch def
 
+    barcode length 300 gt {  % (8110) + value (X..70) at 4:1 ^NNN parse expansion
+        /bwipp.gs1northamericancouponinputTooLong (The input data is too long) //raiseerror exec
+    } if
+
     /_render
         dontdraw /uk.co.terryburton.bwipp.global_ctx dup where {exch get /enabledontdraw known} {pop false} ifelse and
         /uk.co.terryburton.bwipp._dontdraw dup where {exch get} {pop false} ifelse or not

src/gs1process.ps.src

@@ -2376,12 +2376,11 @@ begin
             exch pop exch
             (\() search { exch pop exch } { () } ifelse
         } loop
-        counttomark dup 0 gt {dup 2 idiv 1 add -1 exch {-1 roll} for} {pop} ifelse
-        counttomark 2 idiv array astore /ais exch def
-        counttomark array astore [ exch {  % Expand ordinals of the form ^NNN to ASCII
-            << /parse parse /parseonly true /parsefnc false >> //parseinput exec
-        } forall ] /vals exch def
-        pop
+        counttomark array astore exch pop /aivals exch def
+        /ais [ 0 2 aivals length 1 sub { aivals exch get } for ] def
+        /vals [ 1 2 aivals length 1 sub {  % Expand ordinals of the form ^NNN to ASCII
+            aivals exch get << /parse parse /parseonly true /parsefnc false >> //parseinput exec
+        } for ] def
 
     } {  % Digital Link URI
 

tests/ps_tests/gs1-cc.ps.test

@@ -39,6 +39,8 @@
 { ()      ()             gs1-cc }                            /bwipp.GS1aiMissingOpenParen isError
 { ()      (lintype=upca) gs1-cc }                            /bwipp.GS1aiMissingOpenParen isError
 
+{ 10001 string ()        gs1-cc }                            /bwipp.gs1ccinputTooLong     isError
+
 { ((90)1) (ccversion=d)  gs1-cc }                            /bwipp.gs1ccBadCCversion     isError
 { ((90)1) (cccolumns=31) gs1-cc }                            /bwipp.gs1ccColumnsTooBig    isError
 { ((90)1) (cccolumns=0)  gs1-cc }                            /bwipp.gs1ccBadColumns       isError

tests/ps_tests/gs1northamericancoupon.ps.test

@@ -112,6 +112,7 @@ eq_tmpl_opts
 { ((01)09501101530003) (dontdraw) gs1northamericancoupon } /bwipp.gs1northamericancouponBadAIStructure isError
 { ((8110)7123456789012) (dontdraw dontlint) gs1northamericancoupon } /bwipp.gs1northamericancouponBadVLI isError
 { ((8110)012345) (dontdraw dontlint) gs1northamericancoupon } /bwipp.gs1northamericancouponTooShort isError
+{ 301 string (dontdraw) gs1northamericancoupon } /bwipp.gs1northamericancouponinputTooLong isError
 
 % strictspec smoke test
 { 0 0 moveto (\(8110\)106141416543213500110000310123196000) (includetext segments=8 strictspec xdim=0.330) gs1northamericancoupon true } true isEqual

tests/ps_tests/gs1process.ps.test

@@ -1047,6 +1047,12 @@
 % Missing close paren in AI
 (\(01) /bwipp.GS1aiMissingCloseParen er_tmpl
 
+% Multi-AI parse preserves AI and value order and pairing
+{ ((01)12312312312319(21)ABC123(8030)1) /ai gs1process pop pop }
+[ (01) (21) (8030) ] isEqual
+{ ((01)12312312312319(21)ABC123(8030)1) /ai gs1process pop exch pop }
+[ (12312312312319) (ABC123) (1) ] isEqual
+
 % Requisite linting disabled
 /lintreqs false def
 ((02)12345678901231) good_tmpl