Tests: Update rsecprime tests to the reversed-coefficients convention

The helper now derives the ECC count from the length of the reversed
coefficients array rather than taking a separate nc operand.

Author: terryburton

tests/ps_tests/rsecprime.ps.test

@@ -10,56 +10,62 @@
 % Standalone tests for the rsecprime helper (streaming RSEC over GF(p)).
 % Uses small primes so expected values can be hand-computed.
 %
+% Calling convention:
+%
+%   {getdata} nd coeffsrev lfsr p //rsecprime exec
+%
+% where coeffsrev holds the generator coefficients reversed.
+%
 
 /rsecprime dup /uk.co.terryburton.bwipp findresource cvx def
 
 %
-% Test 1: Minimal case. p=11, nc=1, nd=1, data=[3], coeffs=[7].
+% Test 1: Minimal case. p=11, nc=1, nd=1, data=[3], coeffsrev=[7].
 % Hand-computed:
 %   lfsr = [0]
 %   m=0: fb = (3 - 0) mod 11 = 3
 %     inner j loop has nc-2 = -1 range -> no iterations
-%     lfsr[0] = (coeffs[0] * fb) mod 11 = (7*3) mod 11 = 10
+%     lfsr[0] = (coeffsrev[0] * fb) mod 11 = (7*3) mod 11 = 10
 % Expected ECC = [10]
 %
 /rsdata [3] def
 /lfsr 1 array def
-{ rsdata exch get } 1 [7] 1 lfsr 11 //rsecprime exec
+{ rsdata exch get } 1 [7] lfsr 11 //rsecprime exec
 lfsr 0 1 getinterval
 [10] debugIsEqual
 
 %
-% Test 2: nc=2, nd=1, p=11, data=[3], coeffs=[2, 3].
+% Test 2: nc=2, nd=1, p=11, data=[3], coeffsrev=[3, 2].
 % Hand-computed:
 %   lfsr = [0, 0]
 %   m=0: fb = (3 - 0) mod 11 = 3
-%     j=0: lfsr[0] = (lfsr[1] + coeffs[1]*fb) mod 11 = (0 + 3*3) mod 11 = 9
-%     lfsr[1] = (coeffs[0] * fb) mod 11 = (2*3) mod 11 = 6
+%     j=0: lfsr[0] = (lfsr[1] + coeffsrev[0]*fb) mod 11 = (0 + 3*3) mod 11 = 9
+%     lfsr[1] = (coeffsrev[1] * fb) mod 11 = (2*3) mod 11 = 6
 % Expected ECC = [9, 6]
 %
 /lfsr 2 array def
-{ rsdata exch get } 1 [2 3] 2 lfsr 11 //rsecprime exec
+{ rsdata exch get } 1 [3 2] lfsr 11 //rsecprime exec
 lfsr 0 2 getinterval
 [9 6] debugIsEqual
 
 %
-% Test 3: nc=2, nd=2, p=11, data=[3, 5], coeffs=[2, 3].
+% Test 3: nc=2, nd=2, p=11, data=[3, 5], coeffsrev=[3, 2].
 % After m=0 as Test 2: lfsr = [9, 6]
 %   m=1: fb = (5 - 9 + 11) mod 11 = 7
 %     j=0: lfsr[0] = (lfsr[1] + 3*7) mod 11 = (6 + 21) mod 11 = 5
 %     lfsr[1] = (2 * 7) mod 11 = 14 mod 11 = 3
 % Expected ECC = [5, 3]
 %
 /rsdata [3 5] def
-{ rsdata exch get } 2 [2 3] 2 lfsr 11 //rsecprime exec
+{ rsdata exch get } 2 [3 2] lfsr 11 //rsecprime exec
 lfsr 0 2 getinterval
 [5 3] debugIsEqual
 
 %
 % Test 4: nd=0 boundary. Empty data -> ECC stays all zero.
 %
 /lfsr 3 array def
-{ rsdata exch get } 0 [1 2 3] 3 lfsr 11 //rsecprime exec
+{ rsdata exch get } 0 [3 2 1] lfsr 11 //rsecprime exec
 lfsr 0 3 getinterval
 [0 0 0] debugIsEqual
 
@@ -70,25 +76,20 @@ lfsr 0 3 getinterval
 /lfsr 2 array def
 /rsdata [3] def
 % p=11
-{ rsdata exch get } 1 [2 3] 2 lfsr 11 //rsecprime exec
+{ rsdata exch get } 1 [3 2] lfsr 11 //rsecprime exec
 lfsr 0 2 getinterval
 [9 6] debugIsEqual
 % p=13 with same buffer. Hand-computed:
 %   fb = 3 mod 13 = 3
 %   j=0: lfsr[0] = (0 + 3*3) mod 13 = 9
 %   lfsr[1] = (2*3) mod 13 = 6
-{ rsdata exch get } 1 [2 3] 2 lfsr 13 //rsecprime exec
+{ rsdata exch get } 1 [3 2] lfsr 13 //rsecprime exec
 lfsr 0 2 getinterval
 [9 6] debugIsEqual
 
 %
-% Test 6: Smoke test with p=929 (PDF417's field). Not hand-computed; captures
-% the helper's output as a regression guard for PDF417-sized arithmetic.
-%
-/rsdata [100 200 300] def
-/lfsr 2 array def
-{ rsdata exch get } 3 [500 600] 2 lfsr 929 //rsecprime exec
-% Expected: verified against direct computation with the helper in current state.
+% Test 6: Smoke test with p=929 (PDF417's field), coeffsrev=[600, 500].
+% Hand-computed:
 %   m=0: fb = (100-0) mod 929 = 100
 %     j=0: S[0] = (0 + 600*100) mod 929 = 60000 mod 929 = 60000 - 64*929 = 544
 %     S[1] = (500*100) mod 929 = 50000 mod 929 = 50000 - 53*929 = 763
@@ -100,5 +101,9 @@ lfsr 0 2 getinterval
 %     j=0: S[0] = (794 + 600*628) mod 929 = (794+376800) mod 929 = 377594 mod 929; 929*406 = 377174; 377594-377174 = 420
 %     S[1] = (500*628) mod 929 = 314000 mod 929; 929*337 = 313073; 314000-313073 = 927
 % Expected ECC = [420 927]
+%
+/rsdata [100 200 300] def
+/lfsr 2 array def
+{ rsdata exch get } 3 [600 500] lfsr 929 //rsecprime exec
 lfsr 0 2 getinterval
 [420 927] debugIsEqual