Fix border line with non-Islands themes and consistent panel spacing#40
Open
mervanhasancalik wants to merge 1 commit into
Open
Fix border line with non-Islands themes and consistent panel spacing#40mervanhasancalik wants to merge 1 commit into
mervanhasancalik wants to merge 1 commit into
Conversation
- Add transparent colorCustomizations for activityBar.border and sideBar.border to prevent visible border lines when users use non-Islands base themes (e.g. Default Dark Modern) - Add consistent bottom margins to sidebar, editor, and bottom panel so all floating islands have equal spacing on all sides - Use overflow: clip instead of overflow: hidden on bottom panel to prevent tab bar clipping when switching panel views
mervanhasancalik
force-pushed
the
fix/border-line-and-panel-spacing
branch
from
3fa139e to
e1bc138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users use a base theme like "Default Dark Modern", a vertical border line appears behind the floating sidebar.
This is because Dark Modern sets activityBar.border and sideBar.border to #2B2B2B. Adding transparent colorCustomizations prevents this.
The sidebar, editor, and bottom panel had no bottom margins, causing them to be flush against the bottom Added consistent 8px margins so all floating islands have equal spacing on all sides, matching the existing top and side spacing.
Changed "overflow: hidden" to "overflow: clip" on the bottom panel to prevent the tab bar (Problems, Output, Terminal, etc.) from clipping when switching between panel views. "overflow: clip" provides the same visual clipping without interfering with VS Code's internal layout recalculations.