This repository was archived by the owner on Jun 18, 2025. It is now read-only.
added unit tests for helpers and encrypt_decrypt#38
Open
lkolluru05 wants to merge 8 commits into
Open
Conversation
eshen1991
suggested changes
Jan 13, 2025
Collaborator
eshen1991
left a comment
eshen1991
left a comment
There was a problem hiding this comment.
some recommendations.
eshen1991
reviewed
Jan 14, 2025
Collaborator
There was a problem hiding this comment.
@lkolluru05 Can you also add a target in the Makefile for unit test and the unit test should also be included in the default target when user runs just "make"
eshen1991
reviewed
Jan 15, 2025
eshen1991
reviewed
Jan 15, 2025
| } | ||
|
|
||
|
|
||
| func TestEncryptBytesdo(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
what's "do" at the end of the func name?
Collaborator
Author
There was a problem hiding this comment.
if I write tests , I am unable to run these tests, may its because its a private function , not sure
| @@ -0,0 +1,105 @@ | |||
| package main | |||
Collaborator
There was a problem hiding this comment.
Is this just a place holder?
Collaborator
Author
There was a problem hiding this comment.
yes for now , I have to write tests and check
eshen1991
changed the title
eshen1991
changed the title
Owner
|
Shelving for now, do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.