This repository was archived by the owner on Jun 18, 2025. It is now read-only.
cache implemented for kms clients#59
Draft
lkolluru05 wants to merge 3 commits into
Draft
Conversation
| return base64MD5Hash | ||
| } | ||
|
|
||
| func GetKMSEnvelopeClient(resourceName string) (*aead.KMSEnvelopeAEAD, error){ |
There was a problem hiding this comment.
Looks good, please rename
GetKMSEnvelopeClient => getCachedKMSEnvelopeClient
and
getNewKMSEnvelopeClient => getKMSEnvelopeClient
This will aid readability.
There was a problem hiding this comment.
OR maybe better,
chage GetKMSEnvelopeClient to return getNewKMSEnvelopeClient if not found instead of an error, and onluy call GetKMSEnvelopeClient
I kinda like that a little better but up to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.