EvaluteRTE: Correctly report AbortOnValue aborts with negative abort codes

We need to assume that all error codes not being -1, -2, -3, -4 are from
AbortOnValue as we can't differentiate them. This now correctly reports
AbortOnValue aborts with negative abort codes.

Broken since a7ab54c (More detailed RTE error message, 2017-03-07). It did
not help that the Igor Pro documentation is also wrong in this regard.

Author: t-b

procedures/igortest-basics.ipf

@@ -453,15 +453,14 @@ static Function EvaluateRTE(err, errmessage, abortCode, funcName, funcType, proc
 				IUTF_Reporting#AddError(str, IUTF_STATUS_ERROR)
 				break
 			default:
+				if(abortCode != 0)
+					sprintf str, "Encountered \"AbortOnValue\" Code %d in %s \"%s\" (%s)", abortCode, funcTypeString, funcName, procWin
+					IUTF_Reporting#AddFailedSummaryInfo(str)
+					IUTF_Reporting#AddError(str, IUTF_STATUS_ERROR)
+				endif
 				break
 		endswitch
 		message += str
-		if(abortCode > 0)
-			sprintf str, "Encountered \"AbortOnValue\" Code %d in %s \"%s\" (%s)", abortCode, funcTypeString, funcName, procWin
-			IUTF_Reporting#AddFailedSummaryInfo(str)
-			IUTF_Reporting#AddError(str, IUTF_STATUS_ERROR)
-			message += str
-		endif
 	endif
 
 	IUTF_Reporting#ReportError(message, incrGlobalErrorCounter = 0)

tests/UnitTests/Utils/AbortedTests.ipf

@@ -0,0 +1,31 @@
+#pragma rtGlobals=3
+#pragma TextEncoding="UTF-8"
+#pragma rtFunctionErrors=1
+#pragma version=1.10
+#pragma ModuleName=TEST_Aborted
+
+static Function TEST_CASE_BEGIN_OVERRIDE(string testcase)
+
+	variable/G root:historyRef = CaptureHistoryStart()
+End
+
+static Function TEST_CASE_END_OVERRIDE(string testcase)
+
+	NVAR/SDFR=root: historyRef
+	string/G root:history = CaptureHistory(historyRef, 1)
+End
+
+// IUTF_EXPECTED_FAILURE
+static Function AbortWithNegativeValue()
+
+	AbortOnValue 1, -10
+End
+
+static Function EvaluateAbortWithNegativeValue()
+
+	SVAR/SDFR=root: history
+
+	INFO("%s", s0 = history)
+
+	CHECK_GE_VAR(strsearch(history, "Encountered \"AbortOnValue\" Code -10 in test case \"TEST_Aborted#AbortWithNegativeValue\" (AbortedTestcases.ipf)", 0), 0)
+End

tests/UnitTests/main.ipf

@@ -10,6 +10,7 @@
 #include ":Tracing:ComplexityTests"
 #include ":Utils:PathsTests"
 #include ":Utils:StringsTests"
+#include ":Utils:AbortedTests"
 
 #undef UTF_ALLOW_TRACING
 #if Exists("TUFXOP_Version")