feat: implement high-ROI milestone 3 administrative operations (#20)

* feat: implement high-ROI milestone 3 administrative operations

Add support for 7 commonly-used MongoDB administrative methods:

Index Management:
- db.collection.createIndex(keys, options?)
- db.collection.dropIndex(index)
- db.collection.dropIndexes()

Collection Management:
- db.collection.drop()
- db.collection.renameCollection(newName, dropTarget?)

Database Management:
- db.createCollection(name)
- db.dropDatabase()

Lower-ROI methods (stats, serverStatus, etc.) remain as planned
operations with PlannedOperationError for fallback to mongosh.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: address PR review comments

- createCollection(): reject options argument (not supported yet)
- dropIndexes(): reject array argument instead of silently dropping all
- createIndex(): reject unsupported options instead of ignoring them
- Remove unused IndexModels field and IndexModel type

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: enhance M3 admin operations with extended options support

Address PR review feedback by implementing proper support instead of
rejecting unsupported features:

createCollection options:
- capped: boolean for capped collections
- size: size in bytes for capped collections
- max: max documents for capped collections
- validator: validation rules document
- validationLevel/validationAction: validation settings

createIndex options:
- unique: boolean for unique indexes
- sparse: boolean for sparse indexes
- expireAfterSeconds: TTL index support
- background: accepted but deprecated (no-op)

dropIndexes enhancements:
- Support array of index names to drop multiple specific indexes

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: centralize numeric helper functions in translator package

Address PR review comment about duplicate toInt64 helper by:
- Exporting ToInt64 and ToInt32 from translator/helpers.go
- Removing duplicate toInt64 from executor/admin.go
- Using translator.ToInt64 in executor for numeric comparisons

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: h3n4l

admin_test.go

@@ -34,13 +34,14 @@ func TestPlannedOperation(t *testing.T) {
 		gc := gomongo.NewClient(db.Client)
 		ctx := context.Background()
 
-		// createIndex is a planned M3 operation - should return PlannedOperationError
-		_, err := gc.Execute(ctx, dbName, "db.users.createIndex({ name: 1 })")
+		// createIndexes is a planned M3 operation - should return PlannedOperationError
+		// (createIndex is now implemented, so we use createIndexes instead)
+		_, err := gc.Execute(ctx, dbName, "db.users.createIndexes([{ key: { name: 1 } }])")
 		require.Error(t, err)
 
 		var plannedErr *gomongo.PlannedOperationError
 		require.ErrorAs(t, err, &plannedErr)
-		require.Equal(t, "createIndex()", plannedErr.Operation)
+		require.Equal(t, "createIndexes()", plannedErr.Operation)
 	})
 }
 
@@ -83,9 +84,12 @@ func TestUnsupportedOptionError(t *testing.T) {
 func TestMethodRegistryStats(t *testing.T) {
 	total := gomongo.MethodRegistryStats()
 
-	// Registry should contain M3 (22) planned methods
-	// M2 write operations have been implemented and removed from the registry
-	require.Equal(t, 22, total, "expected 22 planned methods in registry (M3: 22)")
+	// Registry should contain 15 planned methods after M3 high-ROI implementations
+	// M3 high-ROI methods implemented (removed from registry):
+	//   - createIndex, dropIndex, dropIndexes (index management: 3)
+	//   - drop, createCollection, dropDatabase, renameCollection (collection management: 4)
+	// M3 remaining planned methods: 15 (originally 22)
+	require.Equal(t, 15, total, "expected 15 planned methods in registry (M3 remaining)")
 
 	// Log stats for visibility
 	t.Logf("Method Registry Stats: total=%d planned methods", total)

error_test.go

@@ -0,0 +1,295 @@
+package executor
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/bytebase/gomongo/internal/translator"
+	"go.mongodb.org/mongo-driver/v2/bson"
+	"go.mongodb.org/mongo-driver/v2/mongo"
+	"go.mongodb.org/mongo-driver/v2/mongo/options"
+)
+
+// executeCreateIndex executes a db.collection.createIndex() command.
+func executeCreateIndex(ctx context.Context, client *mongo.Client, database string, op *translator.Operation) (*Result, error) {
+	collection := client.Database(database).Collection(op.Collection)
+
+	indexModel := mongo.IndexModel{
+		Keys: op.IndexKeys,
+	}
+
+	// Build index options
+	opts := options.Index()
+	hasOptions := false
+
+	if op.IndexName != "" {
+		opts.SetName(op.IndexName)
+		hasOptions = true
+	}
+	if op.IndexUnique != nil && *op.IndexUnique {
+		opts.SetUnique(true)
+		hasOptions = true
+	}
+	if op.IndexSparse != nil && *op.IndexSparse {
+		opts.SetSparse(true)
+		hasOptions = true
+	}
+	if op.IndexTTL != nil {
+		opts.SetExpireAfterSeconds(*op.IndexTTL)
+		hasOptions = true
+	}
+
+	if hasOptions {
+		indexModel.Options = opts
+	}
+
+	indexName, err := collection.Indexes().CreateOne(ctx, indexModel)
+	if err != nil {
+		return nil, fmt.Errorf("createIndex failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{indexName},
+		RowCount: 1,
+	}, nil
+}
+
+// executeDropIndex executes a db.collection.dropIndex() command.
+func executeDropIndex(ctx context.Context, client *mongo.Client, database string, op *translator.Operation) (*Result, error) {
+	collection := client.Database(database).Collection(op.Collection)
+
+	var err error
+	if op.IndexName != "" {
+		// Drop by index name
+		err = collection.Indexes().DropOne(ctx, op.IndexName)
+	} else if op.IndexKeys != nil {
+		// Drop by index key specification - need to find the index name first
+		cursor, listErr := collection.Indexes().List(ctx)
+		if listErr != nil {
+			return nil, fmt.Errorf("dropIndex failed: %w", listErr)
+		}
+		defer func() { _ = cursor.Close(ctx) }()
+
+		var indexName string
+		for cursor.Next(ctx) {
+			var idx bson.M
+			if decodeErr := cursor.Decode(&idx); decodeErr != nil {
+				return nil, fmt.Errorf("dropIndex failed: %w", decodeErr)
+			}
+			// Check if keys match
+			if keysMatch(idx["key"], op.IndexKeys) {
+				indexName, _ = idx["name"].(string)
+				break
+			}
+		}
+		if indexName == "" {
+			return nil, fmt.Errorf("dropIndex failed: index not found")
+		}
+		err = collection.Indexes().DropOne(ctx, indexName)
+	} else {
+		return nil, fmt.Errorf("dropIndex failed: no index specified")
+	}
+
+	if err != nil {
+		return nil, fmt.Errorf("dropIndex failed: %w", err)
+	}
+
+	response := bson.M{"ok": 1}
+	jsonBytes, err := bson.MarshalExtJSONIndent(response, false, false, "", "  ")
+	if err != nil {
+		return nil, fmt.Errorf("marshal failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{string(jsonBytes)},
+		RowCount: 1,
+	}, nil
+}
+
+// keysMatch compares two index key specifications.
+func keysMatch(a any, b bson.D) bool {
+	switch keys := a.(type) {
+	case bson.D:
+		if len(keys) != len(b) {
+			return false
+		}
+		for i, elem := range keys {
+			if elem.Key != b[i].Key {
+				return false
+			}
+			// Compare values (could be int32, int64, string, etc.)
+			if !valuesEqual(elem.Value, b[i].Value) {
+				return false
+			}
+		}
+		return true
+	case bson.M:
+		if len(keys) != len(b) {
+			return false
+		}
+		for _, elem := range b {
+			val, ok := keys[elem.Key]
+			if !ok {
+				return false
+			}
+			if !valuesEqual(val, elem.Value) {
+				return false
+			}
+		}
+		return true
+	}
+	return false
+}
+
+// valuesEqual compares two values that could be different numeric types.
+func valuesEqual(a, b any) bool {
+	// Convert both to int64 for comparison if they're numeric
+	aInt, aOk := translator.ToInt64(a)
+	bInt, bOk := translator.ToInt64(b)
+	if aOk && bOk {
+		return aInt == bInt
+	}
+	// Otherwise compare directly
+	return a == b
+}
+
+// executeDropIndexes executes a db.collection.dropIndexes() command.
+func executeDropIndexes(ctx context.Context, client *mongo.Client, database string, op *translator.Operation) (*Result, error) {
+	collection := client.Database(database).Collection(op.Collection)
+
+	var err error
+	if len(op.IndexNames) > 0 {
+		// Drop each index in the array
+		for _, name := range op.IndexNames {
+			if dropErr := collection.Indexes().DropOne(ctx, name); dropErr != nil {
+				return nil, fmt.Errorf("dropIndexes failed for index %q: %w", name, dropErr)
+			}
+		}
+	} else if op.IndexName == "*" || op.IndexName == "" {
+		// Drop all indexes (except _id)
+		err = collection.Indexes().DropAll(ctx)
+	} else {
+		// Drop specific index
+		err = collection.Indexes().DropOne(ctx, op.IndexName)
+	}
+
+	if err != nil {
+		return nil, fmt.Errorf("dropIndexes failed: %w", err)
+	}
+
+	response := bson.M{"ok": 1}
+	jsonBytes, err := bson.MarshalExtJSONIndent(response, false, false, "", "  ")
+	if err != nil {
+		return nil, fmt.Errorf("marshal failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{string(jsonBytes)},
+		RowCount: 1,
+	}, nil
+}
+
+// executeDrop executes a db.collection.drop() command.
+func executeDrop(ctx context.Context, client *mongo.Client, database string, op *translator.Operation) (*Result, error) {
+	collection := client.Database(database).Collection(op.Collection)
+
+	err := collection.Drop(ctx)
+	if err != nil {
+		return nil, fmt.Errorf("drop failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{"true"},
+		RowCount: 1,
+	}, nil
+}
+
+// executeCreateCollection executes a db.createCollection() command.
+func executeCreateCollection(ctx context.Context, client *mongo.Client, database string, op *translator.Operation) (*Result, error) {
+	db := client.Database(database)
+
+	// Build create collection options
+	opts := options.CreateCollection()
+	if op.Capped != nil && *op.Capped {
+		opts.SetCapped(true)
+	}
+	if op.CollectionSize != nil {
+		opts.SetSizeInBytes(*op.CollectionSize)
+	}
+	if op.CollectionMax != nil {
+		opts.SetMaxDocuments(*op.CollectionMax)
+	}
+	if op.Validator != nil {
+		opts.SetValidator(op.Validator)
+	}
+	if op.ValidationLevel != "" {
+		opts.SetValidationLevel(op.ValidationLevel)
+	}
+	if op.ValidationAction != "" {
+		opts.SetValidationAction(op.ValidationAction)
+	}
+
+	err := db.CreateCollection(ctx, op.Collection, opts)
+	if err != nil {
+		return nil, fmt.Errorf("createCollection failed: %w", err)
+	}
+
+	response := bson.M{"ok": 1}
+	jsonBytes, err := bson.MarshalExtJSONIndent(response, false, false, "", "  ")
+	if err != nil {
+		return nil, fmt.Errorf("marshal failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{string(jsonBytes)},
+		RowCount: 1,
+	}, nil
+}
+
+// executeDropDatabase executes a db.dropDatabase() command.
+func executeDropDatabase(ctx context.Context, client *mongo.Client, database string) (*Result, error) {
+	err := client.Database(database).Drop(ctx)
+	if err != nil {
+		return nil, fmt.Errorf("dropDatabase failed: %w", err)
+	}
+
+	response := bson.M{"ok": 1, "dropped": database}
+	jsonBytes, err := bson.MarshalExtJSONIndent(response, false, false, "", "  ")
+	if err != nil {
+		return nil, fmt.Errorf("marshal failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{string(jsonBytes)},
+		RowCount: 1,
+	}, nil
+}
+
+// executeRenameCollection executes a db.collection.renameCollection() command.
+func executeRenameCollection(ctx context.Context, client *mongo.Client, database string, op *translator.Operation) (*Result, error) {
+	// MongoDB's renameCollection command needs to be run on admin database
+	// The source is in the form "database.collection"
+	command := bson.D{
+		{Key: "renameCollection", Value: database + "." + op.Collection},
+		{Key: "to", Value: database + "." + op.NewName},
+	}
+	if op.DropTarget != nil && *op.DropTarget {
+		command = append(command, bson.E{Key: "dropTarget", Value: true})
+	}
+
+	result := client.Database("admin").RunCommand(ctx, command)
+	if err := result.Err(); err != nil {
+		return nil, fmt.Errorf("renameCollection failed: %w", err)
+	}
+
+	response := bson.M{"ok": 1}
+	jsonBytes, err := bson.MarshalExtJSONIndent(response, false, false, "", "  ")
+	if err != nil {
+		return nil, fmt.Errorf("marshal failed: %w", err)
+	}
+
+	return &Result{
+		Rows:     []string{string(jsonBytes)},
+		RowCount: 1,
+	}, nil
+}

internal/executor/admin.go

@@ -60,6 +60,21 @@ func Execute(ctx context.Context, client *mongo.Client, database string, op *tra
 		return executeFindOneAndReplace(ctx, client, database, op)
 	case translator.OpFindOneAndDelete:
 		return executeFindOneAndDelete(ctx, client, database, op)
+	// M3: Administrative Operations
+	case translator.OpCreateIndex:
+		return executeCreateIndex(ctx, client, database, op)
+	case translator.OpDropIndex:
+		return executeDropIndex(ctx, client, database, op)
+	case translator.OpDropIndexes:
+		return executeDropIndexes(ctx, client, database, op)
+	case translator.OpDrop:
+		return executeDrop(ctx, client, database, op)
+	case translator.OpCreateCollection:
+		return executeCreateCollection(ctx, client, database, op)
+	case translator.OpDropDatabase:
+		return executeDropDatabase(ctx, client, database)
+	case translator.OpRenameCollection:
+		return executeRenameCollection(ctx, client, database, op)
 	default:
 		return nil, fmt.Errorf("unsupported operation: %s", statement)
 	}

internal/executor/executor.go

@@ -224,3 +224,19 @@ func RunOnAllDBs(t *testing.T, testFn func(t *testing.T, db TestDB)) {
 		})
 	}
 }
+
+// RunOnMongoDBOnly runs a test function only on MongoDB databases (not DocumentDB).
+// Use this for tests that require MongoDB-specific features like renameCollection.
+func RunOnMongoDBOnly(t *testing.T, testFn func(t *testing.T, db TestDB)) {
+	t.Helper()
+	dbs := GetAllClients(t)
+	for _, db := range dbs {
+		// Skip DocumentDB as some operations like renameCollection may not be supported
+		if db.Name == "documentdb" {
+			continue
+		}
+		t.Run(db.Name, func(t *testing.T) {
+			testFn(t, db)
+		})
+	}
+}