Merged
Conversation
Add `options { caseInsensitive = true; }` to DorisLexer.g4 to support
lowercase SQL keywords like `show`, `select`, `from`, etc.
Also add regression tests:
- routine_load.sql: lowercase `show create routine load`
- subquery_comparison.sql: subquery in comparison expression
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds case-insensitive keyword support to the Doris SQL lexer, allowing SQL statements to use lowercase or mixed-case keywords instead of only uppercase.
- Added
caseInsensitiveoption to the ANTLR4 lexer grammar - Updated regression test with lowercase keywords
- Added new regression test with mixed-case keywords
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doris/DorisLexer.g4 | Added options { caseInsensitive = true; } to enable case-insensitive keyword matching in the lexer |
| doris/examples/regression/routine_load.sql | Updated test to use lowercase keywords (show, create, routine, load, for) to validate case insensitivity |
| doris/examples/regression/subquery_comparison.sql | Added new regression test with mixed-case SQL (uppercase SELECT/FROM and lowercase select/from/max) to validate case insensitivity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Doris lexer case insensitive to support lowercase SQL keywords like
show,select,from, etc.Changes
options { caseInsensitive = true; }toDorisLexer.g4routine_load.sql: lowercaseshow create routine load for ...subquery_comparison.sql:SELECT a > (select max(a) from t1) FROM t1Test Plan
🤖 Generated with Claude Code