fix:(rumqttc): Remove tls default provider from dependencies#1021
fix:(rumqttc): Remove tls default provider from dependencies#1021tlevora wants to merge 1 commit into
Conversation
Updating rustls-webpki to 0.103.0 removes default ring tls-provider from dependencies.
|
@tlevora this looks good , but does it break any clients that depend on use-rustls feature ? and i try to review it ASAP |
@giridher-art, you are right this is a breaking change. It basically removes all that According to this issue what is the proper solution? Shall I just modify Then there is a question whether this is a good approach or not. If this commit will be applied as it is and a user of Another solution could be adding another two feature flags to [features]
# this is a current solution
use-rustls-no-provider = ["dep:tokio-rustls", "dep:rustls-webpki", "dep:rustls-pemfile", "dep:rustls-native-certs"]
# proposed features
use-rustls-ring = ["rustls-webpki?/ring"]
use-rustls-aws-lc = ["rustls-webpki?/aws_lc_rs"]Then a user of |
Updating 'rustls-webpki' to 0.103.0 removes default ring tls-provider from 'rustls-webpki' dependency and allows to specifically choose between 'ring' and 'aws-lc-rs'. Consider this commit fixing usage of 'use-rustls-no-provider' feature.