fix(simplerouter): use write_all instead of write in send_data#1042
Open
de-sh wants to merge 1 commit into
Open
fix(simplerouter): use write_all instead of write in send_data#1042de-sh wants to merge 1 commit into
write_all instead of write in send_data#1042de-sh wants to merge 1 commit into
Conversation
AsyncWriteExt::write can perform partial writes when the TCP send buffer is under pressure. send_data silently discarded the byte count and returned Ok(()), so PUBACK and CONNACK packets were silently truncated under benchmark load. The client saw malformed framing, disconnected, and reconnected in a loop — making throughput numbers meaningless and profiling data invalid. Switch to write_all, which retries internally until every byte is sent or returns an error.
de-sh
changed the title
write_all instead of write in send_data
thehouseisonfire
added a commit
to thehouseisonfire/rumqtt
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncWriteExt::writecan perform partial writes when the TCP send buffer is under pressure.send_datasilently discarded the byte count and returned early, soPUBACKandCONNACKpackets were silently truncated under benchmark load. The client saw malformed frames, disconnected, and reconnected in a loop, making throughput numbers meaningless and profiling data invalid.Switches to
write_all, which retries internally until every byte is sent or returns an error if it fails.Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.