perf(v5): replace copy_from_slice in Publish::new and LastWill::new#1043
Open
de-sh wants to merge 2 commits into
Open
perf(v5): replace copy_from_slice in Publish::new and LastWill::new#1043de-sh wants to merge 2 commits into
copy_from_slice in Publish::new and LastWill::new#1043de-sh wants to merge 2 commits into
Conversation
…new` Both used `Bytes::copy_from_slice`, which allocates a String and copies its bytes into a second Bytes allocation before dropping the String. Replace with `Bytes::from` to take ownership of the String's buffer directly — same approach as the v4 Publish constructor — cutting the topic allocation count from 2, down to 1 per publish.
1. `Publish::new` topic bound changed from `T: Into<String>` to `T: Into<Bytes>`. `String::from(&str)` (clone) ~> `Bytes::from(String::into_bytes())` = 0 copies. 2. `handle_publish`/`handle_try_publish`/`handle_publish_bytes` now validate the topic string before consuming it, passing the resulting `Bytes` directly to `Publish::new` instead of passing `&String` (saving on an unnecessary clone).
thehouseisonfire
added a commit
to thehouseisonfire/rumqtt
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both used
Bytes::copy_from_slice, which allocates a String and copies its bytes into a second Bytes allocation before dropping the String. Replace withBytes::fromto take ownership of the String's buffer directly — same approach as the v4 Publish constructor — cutting the topic allocation count from 2, down to 1 per publish.benchmarked with bench/throughput
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.