5320 client - Add shadcn sidebar app shell#5321
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new shadcn-based “app shell” sidebar for the client, replacing the legacy mobile + desktop sidebar components and wiring the new sidebar into the main authenticated layout.
Changes:
- Added a reusable shadcn sidebar implementation (
SidebarProvider,Sidebar, triggers, menu primitives) and a newAppSidebarwrapper for app navigation. - Updated the authenticated app layout to use the new sidebar provider/inset pattern and removed the legacy
MobileSidebar/DesktopSidebarimplementations. - Extended theme tokens to support sidebar colors and added unit tests for the new sidebar components.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| client/tailwind.config.js | Adds sidebar color tokens backed by CSS variables. |
| client/src/styles/index.css | Defines the new --sidebar* CSS variables for theming. |
| client/src/shared/layout/MobileTopNavigation.tsx | Switches mobile header to use SidebarTrigger instead of legacy menu state. |
| client/src/shared/layout/MobileSidebar.tsx | Removes legacy mobile sidebar implementation. |
| client/src/shared/layout/desktop-sidebar/DesktopSidebar.tsx | Removes legacy desktop sidebar implementation. |
| client/src/shared/layout/desktop-sidebar/DesktopSidebar.css | Removes legacy desktop sidebar CSS. |
| client/src/shared/layout/app-sidebar/AppSidebarFooter.tsx | Refactors the sidebar footer/user menu for the new sidebar shell. |
| client/src/shared/layout/app-sidebar/AppSidebarFooter.test.tsx | Adds tests for footer trigger/menu rendering. |
| client/src/shared/layout/app-sidebar/AppSidebar.tsx | Adds the new app navigation sidebar component using shadcn primitives. |
| client/src/shared/layout/app-sidebar/AppSidebar.test.tsx | Adds tests for navigation item rendering/linking. |
| client/src/shared/hooks/use-mobile.tsx | Adds a mobile breakpoint hook used by the sidebar system. |
| client/src/components/ui/sidebar.tsx | Adds the shadcn sidebar primitives and provider/trigger components. |
| client/src/App.tsx | Wires the authenticated layout into SidebarProvider + AppSidebar + SidebarInset. |
| client/components.json | Updates shadcn generator config to place hooks under @/shared/hooks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ivicac
force-pushed
the
5320
branch
2 times, most recently
from
July 6, 2026 09:13
f3acc44 to
1c91355
Compare
ivicac
force-pushed
the
5320
branch
2 times, most recently
from
July 6, 2026 13:08
7530096 to
c6c4ac0
Compare
|
kresimir-coko
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old:
New:
