Skip to content

4754 - tool calling improved#4758

Merged
ivicac merged 13 commits intomasterfrom
4754
Apr 14, 2026
Merged

4754 - tool calling improved#4758
ivicac merged 13 commits intomasterfrom
4754

Conversation

@marko-kriskovic
Copy link
Copy Markdown
Collaborator

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New connector (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@blacksmith-sh

This comment has been minimized.

ivicac added 6 commits April 14, 2026 19:17
…edMocks

Register the newly required ConnectionLifecycleFacade collaborator
alongside the other facade/service mocks declared by the shared
@MockitoBean annotation, so every integration test that composes it
(e.g. ProjectDeploymentFacadeIntTest) loads its ApplicationContext
without hand-rolling a stub.
…haredMocks

Mirror the previous ProjectIntTestConfigurationSharedMocks update so
MCP integration tests that compose WorkspaceConnectionFacadeImpl can
load their ApplicationContext.
Replace the ineffective @SuppressWarnings("E1") with
@SuppressFBWarnings("EI2") so SpotBugs recognises the intentional
reference-storing constructor pattern used by the other facade
implementations in this package and stops failing the build.
@blacksmith-sh

This comment has been minimized.

@blacksmith-sh

This comment has been minimized.

ivicac and others added 2 commits April 14, 2026 19:57
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'client'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ivicac ivicac merged commit 56adb2a into master Apr 14, 2026
6 of 7 checks passed
@ivicac ivicac deleted the 4754 branch April 14, 2026 18:27
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants