4831 client - Fix stale node details panel when switching components sharing an action name#4836
Conversation
…sharing an action name Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a workflow editor regression where the node details panel could show stale ActionDefinition properties when switching between nodes from different components that share the same action name (e.g., openrouter/ask vs openai/ask).
Changes:
- Tighten the “action definition is already current” guard to also compare
componentNameandcomponentVersion, not just the operation name. - Add regression tests covering component switches that reuse the same operation name.
- Add unit tests documenting the updated “freshness” guard behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| client/src/pages/platform/workflow-editor/components/hooks/useWorkflowNodeDetailsPanel.ts | Updates the effect guard to treat action definitions as stale when component identity differs, forcing a refetch. |
| client/src/pages/platform/workflow-editor/tests/WorkflowNodeDetailsPanel.test.tsx | Adds a regression scenario for switching between components that share an action name. |
| client/src/pages/platform/workflow-editor/components/hooks/useWorkflowNodeDetailsPanel.test.ts | Adds tests documenting/validating the updated “freshness” comparison logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ction guard Review feedback flagged that the action-definition freshness guard was duplicated between the hook and both test files, so tests could pass while production regressed. Extract the guard into its own module and have the hook effect plus the unit test import the single implementation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com