Conversation
Contributor
ivicac
commented
Apr 23, 2026
ivicac
commented
- 4798 Require valid type format in WorkflowTaskUtils task detection
- 4798 Skip output generation in VarSetAction when value is null
The name+type heuristic introduced in 1be59ef incorrectly matched user-defined data structures with both fields (e.g., PostgreSQL column definitions {"name": "ime", "type": "STRING"}), causing WorkflowNodeType.ofType("STRING") to throw on workflow save. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses workflow task detection false-positives and avoids generating outputs for var/set when no value is provided.
Changes:
- Skip output generation in
VarSetActionwhen thevalueinput is missing or null. - Refine
WorkflowTaskUtilsnested-task detection by extracting map checks intoisWorkflowTaskMap. - Add a regression test ensuring
List<Map>payloads withname/typekeys (but non-workflowtypevalues) are not treated as tasks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
server/libs/modules/components/var/src/main/java/com/bytechef/component/var/action/VarSetAction.java |
Adds a null check intended to avoid output generation when value is absent/null. |
server/libs/atlas/atlas-configuration/atlas-configuration-api/src/main/java/com/bytechef/atlas/configuration/util/WorkflowTaskUtils.java |
Centralizes and tightens logic used to identify task-like maps in parameters. |
server/libs/atlas/atlas-configuration/atlas-configuration-api/src/test/java/com/bytechef/atlas/configuration/util/WorkflowTaskUtilsTest.java |
Adds coverage for lists of maps that resemble tasks but are actually user data structures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.