Try fixing release-please permissions#256
Merged
tschneidereit merged 1 commit intomainfrom Aug 3, 2025
Merged
Conversation
Let's see if this fixes the release permissions. It at least matches the [release-please action's documentation](https://github.com/googleapis/release-please-action#basic-configuration). In looking at this, I also noticed that the published artifacts aren't quite what I expected—my apologies for not catching this earlier! There's a key difference between the `starling-raw.wasm` and `starling.wasm` builds, and we shouldn't rename the former to the latter for the released artifacts. Instead, I simply added both, so that they can both be made use of directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this fixes the release permissions. It at least matches the release-please action's documentation.
In looking at this, I also noticed that the published artifacts aren't quite what I expected—my apologies for not catching this earlier! There's a key difference between the
starling-raw.wasmandstarling.wasmbuilds, and we shouldn't rename the former to the latter for the released artifacts. Instead, I simply added both, so that they can both be made use of directly.