fix: ✅ Re-instate Response::json() as a static method#263
Merged
tschneidereit merged 1 commit intobytecodealliance:mainfrom Aug 18, 2025
Merged
fix: ✅ Re-instate Response::json() as a static method#263tschneidereit merged 1 commit intobytecodealliance:mainfrom
tschneidereit merged 1 commit intobytecodealliance:mainfrom
Conversation
Attempt to re-create Response.json() as a static method for end-users to consume.
Contributor
Author
|
Thank you.. What is the process for getting this merged and released in the next version? |
Member
|
Thank you indeed, @godronus! I just landed the PR, so it'll be included in our next release. I think we'll do one of those soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to re-create Response.json() as a static method for end-users to consume.
This is my first real incursion into StarlingMonkey internals, so it may be a an overly simplified understanding of what is required.
Confirmed it passes all the WPT tests.
Open to feedback and refactoring if required.