fix(p3-shim): adapt shim to latest bindings#1435
Merged
andreiltd merged 2 commits intobytecodealliance:mainfrom Apr 29, 2026
Merged
fix(p3-shim): adapt shim to latest bindings#1435andreiltd merged 2 commits intobytecodealliance:mainfrom
andreiltd merged 2 commits intobytecodealliance:mainfrom
Conversation
andreiltd
force-pushed
the
fix/p3-shim-batch
branch
from
2e95bac to
55aba82
Compare
vados-cosmonic
approved these changes
Apr 29, 2026
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Left a single nit, and fmt isn't passing yet, but this should be good to go, feel free to merge!
andreiltd
force-pushed
the
fix/p3-shim-batch
branch
2 times, most recently
from
7b995d5 to
ea30a7d
Compare
andreiltd
force-pushed
the
fix/p3-shim-batch
branch
from
ea30a7d to
e2665b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a batch of small adjustments for p3 shim to work with the latest bindgen.