silence deprecation warnings in lucet-benchmarks (#679)

* silence deprecation warnings in lucet-benchmarks

* cargo audit: ignore RUSTSEC-2020-0159

we do not believe this vulnerablity is reachable in our project

* Fix macOS support on Big Sur & Monterey

Co-authored-by: Frank Denis <github@pureftpd.org>

Author: Pat Hickey

.github/workflows/main.yml

@@ -133,7 +133,7 @@ jobs:
     - name: Install Rust (rustup)
       run: rustup update
     - run: cargo install cargo-audit
-    - run: cargo audit
+    - run: cargo audit --ignore RUSTSEC-2020-0159
 
   docs:
     name: Build docs

Makefile

@@ -87,7 +87,7 @@ bench:
 
 .PHONY: audit
 audit:
-	cargo audit
+	cargo audit --ignore RUSTSEC-2020-0159
 
 .PHONY: clean
 clean:

benchmarks/lucet-benchmarks/src/lib.rs

@@ -1,3 +1,9 @@
+// This crate uses several Criterion APIs which are deprecated. However, the
+// Lucet project is in maintence mode and we no longer really care about
+// maintaining and updating these interfaces, so we will ignore these
+// warnings:
+#![allow(deprecated)]
+
 mod compile;
 mod context;
 mod modules;

lucetc/src/lib.rs

@@ -472,9 +472,15 @@ fn ldflags_default(target: &Triple, target_version: &TargetVersion) -> String {
         | OperatingSystem::Freebsd
         | OperatingSystem::Dragonfly
         | OperatingSystem::Netbsd
-        | OperatingSystem::Openbsd => "-shared",
+        | OperatingSystem::Openbsd => "-shared".to_string(),
         OperatingSystem::Darwin | OperatingSystem::MacOSX { .. } => {
-            "-dylib -dead_strip -export_dynamic -undefined dynamic_lookup"
+           let sdk_path = std::process::Command::new("xcrun")
+                .args(&["-sdk", "macosx", "--show-sdk-path"])
+                .output()
+                .expect("xcrun failed")
+                .stdout;
+                let sdk_path = std::str::from_utf8(&sdk_path).expect("invalid sdk_path").trim();
+                format!("-dylib -dead_strip -export_dynamic -undefined dynamic_lookup -L {}/usr/lib -lSystem", sdk_path)
         }
         _ => panic!(
             "Cannot determine default flags for {}.