Skip to content
This repository was archived by the owner on Mar 24, 2022. It is now read-only.

Commit e8e5f9c

Browse files
Lucetc: fix macOS detection (#411)
Lucetc uses `target-lexicon` crate to detect the host OS. On modern Macs, `target-lexicon` reports that the host is `Darwin`, not `MacOSX`, at least I see this on my MacBook Pro running Catalina 10.15.2. This leads to lucetc is not being able to set `LDFLAGS` correctly. This change solves the issue by using the same LDFLAGS on both `Darwin` and `MacOSX`.
1 parent 25bf287 commit e8e5f9c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

lucetc/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ fn ldflags_default(target: &Triple) -> String {
416416

417417
match target.operating_system {
418418
OperatingSystem::Linux => "-shared",
419-
OperatingSystem::MacOSX { .. } => {
419+
OperatingSystem::Darwin | OperatingSystem::MacOSX { .. } => {
420420
"-dylib -dead_strip -export_dynamic -undefined dynamic_lookup"
421421
}
422422
_ => panic!(

0 commit comments

Comments
 (0)